build: setup pre commit hook to check java format#28
Open
ChristianMurphy wants to merge 1 commit intoopenequella:masterfrom
Open
build: setup pre commit hook to check java format#28ChristianMurphy wants to merge 1 commit intoopenequella:masterfrom
ChristianMurphy wants to merge 1 commit intoopenequella:masterfrom
Conversation
* updates gradle wrapper to latest version to enable ghooks to be used. * enables ghooks plugin for gradle * adds google java format pre commit hook * adds test check file output to gitignore resolves openequella#25
Member
Author
|
Also be aware, it appears some of the test suite is failing: edit probably related to the Gradle version update |
Member
|
May want to consider bringing in Checkstyle too for some static code analysis: https://docs.gradle.org/current/userguide/checkstyle_plugin.html |
Member
Author
|
Thanks for the suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #25