Skip to content

chore(deps): lock file maintenance #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 13, 2021

WhiteSource Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: "before 3am on the first day of the month" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Sep 13, 2021

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: react-front-end/package-lock.json
npm notice 
npm notice New minor version of npm available! 7.19.1 -> 7.23.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.23.0>
npm notice Run `npm install -g [email protected]` to update!
npm notice 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: openequella-react-front-end@undefined
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14.0 || ^15.0.0 || ^16.0.0-0" from [email protected]
npm ERR! node_modules/react-html-parser
npm ERR!   react-html-parser@"2.0.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2021-09-13T08_34_48_423Z-debug.log

@edalex-ian
Copy link
Member

Alright, cool, this is good progress. Seems all the updates from @PenghaiZhang has got us past build issues, now we're just into dependency issues.

  1. The build has failed due to runtypes issues; and
  2. Renovate message above is due to an issue we saw way back when we first went to NPM 7. @ChristianMurphy provided one option in chore: add legacy peer dependencies #3262 in using legacy peer dependencies, however react-html-parser seems to be unmaintained for years and there's even a PR offering to address this issue (Add support for react@17 peternewnham/react-html-parser#80) but no one is merging it.

For next action I propose we address react-html-parser directly. Based on the above PRs there are two immediate options:

For the second module, I have a vague memory that at some-point someone in the team may have tried something different but there were issues... Not sure... But so I wonder if that works.

Regardless, it probably makes sense if we can simply use the more popular module, but we don't want to spend too much time.

Once we get past that, then perhaps that'll help renovate properly deliver an updated package-lock.json for the front-end and then perhaps that might also solve the runtypes issue. 🤞

@PenghaiZhang
Copy link
Contributor

I have replaced react-html-parser with html-react-parser.

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PenghaiZhang ! I'll merge now and then request another 'lock file maintenance' from renovate and see if we finally get the all clear. 🤞

@edalex-ian edalex-ian merged commit c607371 into develop Sep 14, 2021
@edalex-ian edalex-ian deleted the renovate/lock-file-maintenance branch September 14, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants