feat: implement TTL secret controller for orphaned secrets cleanup - #958
Open
piyxsh31 wants to merge 1 commit into
Open
feat: implement TTL secret controller for orphaned secrets cleanup#958piyxsh31 wants to merge 1 commit into
piyxsh31 wants to merge 1 commit into
Conversation
Signed-off-by: Piyush <agrawalpiyush415@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
When a
BackupStorageCustom Resource fails to be created (e.g., due to an API error), theSecretcontaining the storage credentials that was just created gets left orphaned. Because there's no parent CR, it lacks anOwnerReferenceand Kubernetes native garbage collection ignores it.Related pull requests
closes: openeverest/openeverest#2332
Cause:
We modified the API handler to apply a TTL annotation instead of doing fragile synchronous deletion on failure. However, the operator needed a mechanism to recognize this annotation and actually perform the asynchronous cleanup of these orphaned Secrets.
Solution:
Introduced a new
SecretReconciler(secret_controller.go) to watch and actively delete orphaned Secrets that still carry the expiredeverest.percona.com/cleanup-afterannotation. UpdatedBackupStorageReconcilerto adopt Secrets by stripping this annotation upon successful CR creation.CHECKLIST
Helm chart
Jira
Tests