Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support structured logging config for faas-netes (Standard/Enterprise) #1184

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

welteki
Copy link
Member

@welteki welteki commented Jan 3, 2024

Description

Support configuring the log level and format for the faas-netes controller (Standard/Enterprise)

faasnetesPro:
  logs:
    debug: false
    format: "console"

Why is this needed?

  • I have raised an issue to propose this change (required)

Logs for OpenFaaS IAM where moved to the debug level. This change is required to support setting the log level when running OpenFaaS IAM with the faas-netes controller mode.

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

Verified the log level and format are set correctly when the chart values are updated:

kubectl logs -n openfaas deploy/gateway -c faas-netes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@welteki welteki changed the title Support structured logging config for faas-netes (Pro/Enterprise) Support structured logging config for faas-netes (Standard/Enterprise) Jan 3, 2024
alexellis
alexellis previously approved these changes Feb 2, 2024
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Support configuration for debug level logging and JSON logging for the
faas-netes controller (Pro/Enterprise).

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
@alexellis alexellis merged commit 44aad06 into openfaas:master Feb 7, 2024
3 checks passed
@welteki welteki deleted the faas-netes-logs branch February 8, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants