Skip to content

Include PLATFORM define for older NDK support #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.3.0-Dev
Choose a base branch
from

Conversation

dimensionscape
Copy link
Member

Hxcpp needs the PLATFORM define for older ndks that require the gcc toolchain. We initially removed it since Lime potentially was going to have a minimum requirement of android sdk 28 due to openal soft version 1.20.1, however, this was solved by upgrading to 1.21.1 which presented no further conflicts with sdk 21.

To simply things, we just provide both defines for now.

Hxcpp needs the PLATFORM define for older ndks that require the gcc toolchain. We initially removed it since Lime potentially was going to have a minimum requirement of android sdk 28 due to openal soft version 1.20.1, however, this was solved by upgrading to 1.21.1 which presented no further conflicts with sdk 21. 

To simply things, we just provide both defines for now.
@tobil4sk
Copy link
Member

We mainly need PLATFORM_NUMBER for hxcpp 4.3.2, where it became configurable however min sdk 21 wasn't set by default yet for 32 bit architectures.

This may actually be useful to go in develop, as it may solve some issues building on android and prevent people having to resort to git hxcpp. Disabling 32 bit builds by default may also help even further even for older versions of hxcpp.

Also note, that at least for builds with openal-soft, you can't build lime with an ndk older than 20, so PLATFORM would never be read in that case. I guess it's possible that builds with mojoal might still work with older ndks but I haven't tested.

@tobil4sk
Copy link
Member

We mainly need PLATFORM_NUMBER for hxcpp 4.3.2

It turns out I had confused myself, 4.3.2 does not include the change so PLATFORM_NUMBER does nothing unless using git hxcpp, where the min sdk is already set to 21 currently. This means we can't really do anything to fix things with hxcpp 4.3.2.

@tobil4sk
Copy link
Member

I've tested with some older ndks (in particular, I was successful with r15 and r17). I had to make some modifications to hxcpp, but I was able to get them compiling when using -Dmojoal, so if we want to continue supporting that then this change makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants