Make JNISafety safe for macro context #2014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression in 8.3.0 (specifically 8f0b8f3) which has broken builds for android apps that use macros, e.g.:
This is because
src/lime/_internal/backend/native/NativeApplication.hxnow hasOrientationChangeListener, which extendsJNISafetywhich is marked with@:autoBuild.We can avoid the error by skipping the
@:autoBuildmeta in the macro context.