feat: Add deep links to Hunger Games Logo game #181
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added Annotate and Kickstart Annotation links (which partially fixes Add deep link to the Hunger Games logo game #80, not fully because Hunger Games KP isn't shown in product pages)
Resolved a bug introduced in fix: return translated description in Hunger Games KP given valid lang_code #175.
Previously translators might have added extra space in
msgstrwith {facet_value} in addition to space added internally (in case facet_value wasn't provided no space was added)E.g:
msgid: "Answer robotoff questions about the {facet_value}{facet_name}"translator msgstr: "translation... {facet_value} {facet_name}"Which would be rendered as "translation... brand nestle" (two spaces between 'brand' and 'nestle')
Now, no extra space is added internally in case facet_value is provided rather it is present in the msgid itself and in case facet_value is not provided then '{facet_value}' along with unnecessary spaces is removed from translated string before plugging the values in placeholders using format_translation
Updated knowledge-panel.pot and tests for changes stated above and changes made in this commit
I'm assuming changing .pot won't cause any problems because it isn't released yet to facets-kp-org.
Fixes bug(s)