Skip to content

Conversation

@Nothingspecial99
Copy link
Contributor

@Nothingspecial99 Nothingspecial99 commented May 7, 2025

What

  • Added Annotate and Kickstart Annotation links (which partially fixes Add deep link to the Hunger Games logo game #80, not fully because Hunger Games KP isn't shown in product pages)

  • Resolved a bug introduced in fix: return translated description in Hunger Games KP given valid lang_code #175.
    Previously translators might have added extra space in msgstr with {facet_value} in addition to space added internally (in case facet_value wasn't provided no space was added)
    E.g:
    msgid: "Answer robotoff questions about the {facet_value}{facet_name}"
    translator msgstr: "translation... {facet_value} {facet_name}"
    Which would be rendered as "translation... brand nestle" (two spaces between 'brand' and 'nestle')
    Now, no extra space is added internally in case facet_value is provided rather it is present in the msgid itself and in case facet_value is not provided then '{facet_value}' along with unnecessary spaces is removed from translated string before plugging the values in placeholders using format_translation

  • Updated knowledge-panel.pot and tests for changes stated above and changes made in this commit
    I'm assuming changing .pot won't cause any problems because it isn't released yet to facets-kp-org.

Fixes bug(s)

@Nothingspecial99
Copy link
Contributor Author

@alexgarel Please review when you get the time :)

@Nothingspecial99
Copy link
Contributor Author

@alexgarel

Adding tooltips on Robotoff and Logo games (inside Hunger Games KP) with basic info about them and text like "You don't need to create any other account if you're already registered on OFF" might encourage people who are unfamiliar with Hunger games and think it might be something complex to contribute.

What do you think, will it be useful or make the KP confusing?

@alexgarel
Copy link
Member

@Nothingspecial99 really sorry, I never reviewed that… :-(

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Knowledge Panels for Facets Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add deep link to the Hunger Games logo game

3 participants