refactor: Refactored api.py into routes. Fixes #232#237
refactor: Refactored api.py into routes. Fixes #232#237nasredeenabdulhaleem wants to merge 1 commit into
Conversation
|
@teolemon Can you help review the PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 5 10 +5
Lines 324 405 +81
=======================================
+ Hits 308 385 +77
- Misses 16 20 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexgarel
left a comment
There was a problem hiding this comment.
This PR is good and clean, thanks @nasredeenabdulhaleem, but merging it now, in this GSoC period, would create a lot of conflict in other PRs
So I'm not sure if we should merge it.
@CharlesNepote what do you think ?
|
Yes it's a good job, but also I would prefer that we achieve this task later on, after many ongoing PRs have been merged. |
|
ok @alexgarel @CharlesNepote Thank You for the feedback |
What
Screenshot
Fixes bug(s)
Part of