fix: Potential fix for code scanning alert no. 1: Construction of a cookie using user-supplied input#116
Draft
fix: Potential fix for code scanning alert no. 1: Construction of a cookie using user-supplied input#116
Conversation
… using user-supplied input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
teolemon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/openfoodfacts/nutripatrol/security/code-scanning/1
To fix the problem, we should ensure that the value used for the session cookie is validated and sanitized before being set. The best approach is to restrict the allowed characters in the session value to a safe subset (e.g., alphanumeric and a few safe symbols), and reject or sanitize any input that does not conform. This can be done by adding a regex validation to the
SessionBodyPydantic model, ensuring that only safe session values are accepted. This change should be made in the definition ofSessionBodyinapp/api.py. No changes to imports are needed, as Pydantic is already imported.Suggested fixes powered by Copilot Autofix. Review carefully before merging.