feat: Add excludedItems parameter to autocomplete function with dynamic size adjustment #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic size adjustment **Description (optional):** - Added `excludedItems` parameter to filter out unwanted items from auto-suggestions. - Dynamically adjusted the `size` parameter to request additional items based on the length of the exclusion list. - Ensured safety by handling potential null values in `excludedItems`. - Improved overall flexibility of the autocomplete functionality.
There was a problem hiding this comment.
Hi @AffanShaikhsurab!
Please have a look at my comments about minor issues.
But other related parts of the code needs to be impacted too:
OpenFoodAPIClient.getSuggestionsAutocompleterAutocompleteManagerTagTypeAutocompleterTaxonomyNameAutocompleter
In addition to that, the code must be tested, in api_suggestion_manager_test.dart and api_search_test.dart.
- Updated impacted components: - `OpenFoodAPIClient.getSuggestions` - `Autocompleter` - `AutocompleteManager` - `TagTypeAutocompleter` - `TaxonomyNameAutocompleter` - Added/updated tests in `api_suggestion_manager_test.dart` and `api_search_test.dart`. - Addressed minor review comments.
|
I have made the changes. Could you please check if they are valid? Also, what should we pass as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
excludedItemsparameter to filter out unwanted items from auto-suggestions.sizeparameter to request additional items based on the length of the exclusion list.excludedItems.Fixes bug(s)
#889
Part of