Skip to content

feat: bring supported wiki country page up to date #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

teolemon
Copy link
Member

What

  • feat: bring supported wiki country page up to date

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teolemon!
Something wrong about American Samoa: is there a link? Anyway it needs to be correctly formatted.

@@ -825,6 +937,7 @@ enum OpenFoodFactsCountry implements OffTagged {
final String offTag;

// TODO(monsieurtanuki): remove ANTARCTICA, with no products and no currency?
// Pierre: prices are probably frozen there. Food is probably also frozen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about global warming?

AMERICAN_SAMOA(
offTag: 'as',
currency: Currency.USD,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something missing here?

@teolemon teolemon requested a review from monsieurtanuki March 13, 2025 16:36
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly said, there are still problems with the format.
Just fixing the French entries may do the trick.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And some other countries...

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed reformatting.

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 13, 2025
@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Dart package - Support for new APIs and issues Mar 13, 2025
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teolemon I'm planning a new off-dart release.
Feel like including this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants