-
-
Notifications
You must be signed in to change notification settings - Fork 72
feat: bring supported wiki country page up to date #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @teolemon!
Something wrong about American Samoa: is there a link? Anyway it needs to be correctly formatted.
@@ -825,6 +937,7 @@ enum OpenFoodFactsCountry implements OffTagged { | |||
final String offTag; | |||
|
|||
// TODO(monsieurtanuki): remove ANTARCTICA, with no products and no currency? | |||
// Pierre: prices are probably frozen there. Food is probably also frozen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about global warming?
lib/src/utils/country_helper.dart
Outdated
AMERICAN_SAMOA( | ||
offTag: 'as', | ||
currency: Currency.USD, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly said, there are still problems with the format.
Just fixing the French entries may do the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And some other countries...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed reformatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teolemon I'm planning a new off-dart release.
Feel like including this PR?
What