feat: 1066 - new parameters for proof upload #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `common_proof_parameters.dart`: Common parameters for the "upload and update proof" API queries, including 5 new fields. * `create_proof_parameters.dart`: Parameters for the "upload proof" API query. Impacted files: * `api_prices_test.dart`: added more tests around proof upload and update; refactored accordingly * `open_prices_api_client.dart`: changed the parameters of `uploadProof` for more flexibility * `openfoodfacts.dart`: added the 2 new files * `proof.dart`: added 4 missing fields * `proof.g.dart`: generated * `update_proof_parameters.dart`: moved code to `CommonProofParameters`
github-project-automation
bot
moved this to In progress
in Dart package - Support for new APIs and issues
github-project-automation
bot
moved this from In progress
to Reviewer approved
in Dart package - Support for new APIs and issues
github-project-automation
bot
moved this from Todo
to Done
in 🧃🛠️ Open Food Facts SDK tracking
github-project-automation
bot
moved this from Reviewer approved
to Done
in Dart package - Support for new APIs and issues
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
readyForPriceTagValidationthat is needed for bulk proof upload in Smoothie.Fixes bug(s)
Part of
Files
New files:
common_proof_parameters.dart: Common parameters for the "upload and update proof" API queries, including 5 new fields.create_proof_parameters.dart: Parameters for the "upload proof" API query.Impacted files:
api_prices_test.dart: added more tests around proof upload and update; refactored accordinglyopen_prices_api_client.dart: changed the parameters ofuploadProoffor more flexibilityopenfoodfacts.dart: added the 2 new filesproof.dart: added 4 missing fieldsproof.g.dart: generatedupdate_proof_parameters.dart: moved code toCommonProofParameters