-
-
Notifications
You must be signed in to change notification settings - Fork 103
docs: Enhance pull request template with guidelines #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
teolemon
wants to merge
2
commits into
develop
Choose a base branch
from
PR-template-fix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,11 +1,37 @@ | ||||||
| <!-- | ||||||
| ⚠️ Acceptance Requirements | ||||||
| **This Pull Request will only be accepted if:** | ||||||
| - ✅ There's an agreement by a maintainer or core contributor in the linked issue to assign it to the author of this PR | ||||||
| --> | ||||||
|
|
||||||
| <!-- | ||||||
| ⚠️ Please name your pull request title following this scheme: `type: What you did` this allows us to automatically generate the changelog | ||||||
| Following `type`s are allowed: | ||||||
| - `feat`, for Features | ||||||
| - `fix`, for Bug Fixes | ||||||
| - `docs`, for Documentation | ||||||
| - `ci`, for Automation | ||||||
| - `style`, for Code style changes (formatting, whitespace, etc.) | ||||||
| - `refactor`, for code Refactoring | ||||||
| - `chore`, for Miscellaneous things | ||||||
| - `test`, for Adding or updating tests | ||||||
| - `build`, for Build system or dependency changes | ||||||
| - `revert`, for Reverting previous changes | ||||||
| - `l10n`, for Localization and translation updates | ||||||
| - `taxonomy`, for Changes to product categories and tags taxonomy | ||||||
| --> | ||||||
|
|
||||||
| ## Description | ||||||
|
|
||||||
| - Brief note about the issue | ||||||
| - Brief note about the Pull Request | ||||||
|
|
||||||
| ## Solution | ||||||
|
|
||||||
| - Mention how your solution resolves the issue | ||||||
|
|
||||||
| ## Related issue(s) | ||||||
| ### Large Language Models usage disclosure | ||||||
| <!-- ⚠️ If you used an LLM, please disclose which LLM you used (and its version) and how (agentic, autocomplete). Please confirm you have run the code successfully on your device (or in CI). Also provide a screenshot or video as proof --> | ||||||
|
|
||||||
| - Fixes #[ISSUE NUMBER] | ||||||
| ### Related issue(s) and discussion | ||||||
| <!-- Please add the issue number this issue will close, that way, once your pull request is merged, the issue will be closed as well --> | ||||||
| - Fixes: <!-- #1 Note: you can also use Closes: --> | ||||||
|
||||||
| - Fixes: <!-- #1 Note: you can also use Closes: --> | |
| - Fixes #<issue-number> <!-- Note: you can also use Closes instead of Fixes --> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title type list includes
l10nandtaxonomy, but the repo’s Semantic PR check runsamannn/action-semantic-pull-request@v6without any type configuration. That action’s defaults typically only allow the standard conventional-commit types, so these extra types may cause PRs to fail CI. Either remove unsupported types from this template or add an explicit configuration for the semantic PR action so the template matches what CI enforces.