Skip to content

refactor(Taxonomy): for dataset filepath, use mapping instead of overriding enum#479

Merged
raphodn merged 1 commit into
developfrom
raphodn/get-taxonomy-oxf-refactor-2
May 11, 2026
Merged

refactor(Taxonomy): for dataset filepath, use mapping instead of overriding enum#479
raphodn merged 1 commit into
developfrom
raphodn/get-taxonomy-oxf-refactor-2

Conversation

@raphodn

@raphodn raphodn commented May 7, 2026

Copy link
Copy Markdown
Member

Description

Follow up of #475

Revert the changes on the TaxonomyType enum, and build the dataset_filepath using a mapping instead

Also add some tests

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

@Freso Freso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphael0202 raphael0202 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@github-project-automation github-project-automation Bot moved this from In progress to Reviewer approved in 🐍 Python SDK - Keep on par with the API May 11, 2026
@raphodn raphodn merged commit e9af704 into develop May 11, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in 🐍 Python SDK - Keep on par with the API May 11, 2026
@raphodn raphodn deleted the raphodn/get-taxonomy-oxf-refactor-2 branch May 11, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants