fix: handle CORS preflight before authentication#13573
Open
TheSanjBot wants to merge 5 commits into
Open
Conversation
github-project-automation
Bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13573 +/- ##
==========================================
+ Coverage 49.21% 54.43% +5.21%
==========================================
Files 97 98 +1
Lines 25555 25613 +58
Branches 6105 6114 +9
==========================================
+ Hits 12578 13942 +1364
+ Misses 11346 9870 -1476
- Partials 1631 1801 +170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from To discuss and validate
to Done
in 🍊 Open Food Facts Server issues
Member
|
Thanks @TheSanjBot ! Really cool. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Handle CORS preflight requests before authentication runs.
Browsers dont send authentication cookies with preflight
OPTIONSrequests, so routes could fail before CORS headers were added. This caused the blockThis keeps the change narrow by returning early only for real preflight requests:
OPTIONSrequests with bothOriginandAccess-Control-Request-Methodheaders.Added a regression test for a facet preflight request.
Large Language Models usage disclosure
Used ChatGPT to understand the CORS code paths
Related issue(s) and discussion