taxonomy(nutrients): separate vit D₃ out from vit D - #13713
Merged
Conversation
“Vitamin D” specified on packaging can be one of several compounds, but we’re currently just assuming that it’s cholecalciferol (D₃), even if ergocalciferol (D₂) is also reasonably common, with other variants being more rare. This separates out cholecalciferol/vitamin D₃ from the current `vitamin-d` nutrients entry into a new `vitamin-d3` block. Translations are taken from Wikidata and/or adapted from current vitamin D ones. This may (eventually, as products get updated) introduce some issues for data quality calculations that check for `vitamin-d` specifically, e.g. for “source of vitamin D” labels. I’m not sure what the best way to handle this would/will be. Needed-for: https://world.openfoodfacts.org/product/8723300710739/vitamine-d-10-innovit Needed-for: https://dk.openfoodfacts.org/product/5711657050021/vitamin-d3-bodylab
github-project-automation
Bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
github-actions
Bot
added
🧬 Taxonomies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13713 +/- ##
==========================================
+ Coverage 49.48% 54.75% +5.27%
==========================================
Files 99 100 +1
Lines 25841 25899 +58
Branches 6173 6182 +9
==========================================
+ Hits 12787 14182 +1395
+ Misses 11392 9882 -1510
- Partials 1662 1835 +173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
github-project-automation
Bot
moved this from To discuss and validate
to Done
in 🍊 Open Food Facts Server issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
“Vitamin D” specified on packaging can be one of several compounds, but we’re currently just assuming that it’s cholecalciferol (D₃), even if ergocalciferol (D₂) is also reasonably common, with other variants being more rare.
This separates out cholecalciferol/vitamin D₃ from the current
vitamin-dnutrients entry into a newvitamin-d3block.Translations are taken/adapted from Wikidata and/or current vitamin D ones.
This may (eventually, as products get updated) introduce some issues for data quality calculations that check for
vitamin-dspecifically, e.g. for “source of vitamin D” labels. I’m not sure what the best way to handle this would/will be.Needed-for: https://world.openfoodfacts.org/product/8723300710739/vitamine-d-10-innovit
Needed-for: https://dk.openfoodfacts.org/product/5711657050021/vitamin-d3-bodylab