fix: Issues found during STO to JSON migration - #13714
Merged
Merged
Conversation
Signed-off-by: John Gomersall <thegoms@gmail.com>
github-project-automation
Bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
Member
|
A file with those problematic products would indeed be very interesting |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13714 +/- ##
==========================================
+ Coverage 49.58% 54.83% +5.25%
==========================================
Files 99 100 +1
Lines 25846 25904 +58
Branches 6172 6181 +9
==========================================
+ Hits 12816 14205 +1389
+ Misses 11360 9867 -1493
- Partials 1670 1832 +162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
I'll upload the log to this issue when it's done |
Contributor
Author
|
@teolemon FYI log file attached. The lines with "Error processing..." are showing files in the product directory that are not valid JSON or STO files. Note there are a few re-starts in there. |
Signed-off-by: John Gomersall <thegoms@gmail.com>
john-gom
marked this pull request as ready for review
June 6, 2026 10:50
|
john-gom
enabled auto-merge (squash)
June 6, 2026 11:09
github-project-automation
Bot
moved this from To discuss and validate
to Done
in 🍊 Open Food Facts Server issues
stephanegigandet
pushed a commit
that referenced
this pull request
Jun 8, 2026
🤖 I have created a release *beep* *boop* --- ## [2.94.0](v2.93.1...v2.94.0) (2026-06-08) ### Features * FDC import script ([#13320](#13320)) ([264c146](264c146)) ### Bug Fixes * add U+25CF (●) to ingredient separators for Japanese labels ([#13691](#13691)) ([ed740f6](ed740f6)) * backward compatibility for API ask for refactored tags fields ([#13689](#13689)) ([345779e](345779e)) * Issues found during STO to JSON migration ([#13714](#13714)) ([ccfee79](ccfee79)) * nginx priority map ([#13723](#13723)) ([4068a1e](4068a1e)) * reset to-be-exported on pro platform ([#13703](#13703)) ([ac8cc84](ac8cc84)) * use recipe estimator for ingredient analysis (and test tool) ([#13715](#13715)) ([1768b7d](1768b7d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What