Skip to content

taxonomy(food): dietary supplements edits - #13716

Merged
Freso merged 1 commit into
mainfrom
freso/taxonomy/supplements
Jun 17, 2026
Merged

taxonomy(food): dietary supplements edits#13716
Freso merged 1 commit into
mainfrom
freso/taxonomy/supplements

Conversation

@Freso

@Freso Freso commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

I was browsing the “Vitamins” category facet and noticed several mineral supplements being listed there, and realising they didn’t have a good other “home” (best would be the very generic “Dietary supplements”). Additionally, a number of single-vitamin supplements seemed fairly common and probably common enough to have their own categories.

As such, this PR:

  • Makes category names explicitly specify that they’re supplements.
  • Adds a number of new categories:
    • Vitamin B₁₂, C, and D₃ supplements
    • Mineral supplements, incl. calcium, iron, magnesium, and zinc ones.
    • Translations mostly from Wikidata.
  • Renames “Vitamin mineral combinations” to “Multivitamin and mineral supplements”
    • “Multivitamins” is colloquially used for supplements containing both vitamins and minerals and possibly other dietary supplements too.
  • Adds/updates some wikidata properties.

@Freso Freso added the vitamins label Jun 4, 2026
@github-actions github-actions Bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Jun 4, 2026
@github-project-automation github-project-automation Bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Jun 4, 2026
@Freso

This comment was marked as resolved.

@openfoodfacts-bot
openfoodfacts-bot requested a review from a team as a code owner June 4, 2026 15:23
@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (a4889dd) to head (40e7353).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13716      +/-   ##
==========================================
+ Coverage   49.58%   54.83%   +5.25%     
==========================================
  Files          99      100       +1     
  Lines       25846    25904      +58     
  Branches     6172     6181       +9     
==========================================
+ Hits        12816    14205    +1389     
+ Misses      11360     9867    -1493     
- Partials     1670     1832     +162     
Flag Coverage Δ
integration-test-group-1 9.09% <ø> (?)
integration-test-group-2 9.25% <ø> (?)
integration-test-group-3 33.05% <ø> (?)
integration-test-group-4 28.69% <ø> (?)
integration-test-group-5 9.15% <ø> (?)
integration-test-group-6 9.69% <ø> (?)
integration-test-group-7 28.25% <ø> (?)
integration-test-group-8 26.50% <ø> (?)
integration-test-group-9 13.17% <ø> (?)
unit-test-group-1 24.13% <ø> (ø)
unit-test-group-2 34.84% <ø> (ø)
unit-test-group-3 23.49% <ø> (ø)
unit-test-group-4 29.88% <ø> (-0.01%) ⬇️
unit-test-group-5 17.23% <ø> (ø)
unit-test-group-6 27.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Freso
Freso force-pushed the freso/taxonomy/supplements branch from 9312261 to d6ef1ee Compare June 4, 2026 20:19
@Freso
Freso force-pushed the freso/taxonomy/supplements branch 3 times, most recently from a4ae49d to eacbc9d Compare June 4, 2026 22:21
@stephanegigandet

This comment was marked as resolved.

@Freso

This comment was marked as resolved.

@github-actions github-actions Bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 5, 2026
@Freso
Freso force-pushed the freso/taxonomy/supplements branch from ab8f976 to 57cc1e3 Compare June 5, 2026 12:38
@github-actions github-actions Bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 5, 2026
I was browsing the “Vitamins” category facet and noticed several mineral
supplements being listed there, and realising they didn’t have a good
other “home” (best would be the very generic “Dietary supplements”).
Additionally, a number of single-vitamin supplements seemed fairly
common and probably common enough to have their own categories.

As such, this PR:
- Makes category names explicitly specify that they’re supplements.
- Adds a number of new categories:
  - Vitamin B₁₂, C, and D₃ supplements
  - Mineral supplements, incl. calcium, iron, magnesium, and zinc ones.
  - Translations mostly from Wikidata.
- Renames “Vitamin mineral combinations” to
  “Multivitamin and mineral supplements”
  - “Multivitamins” is colloquially used for supplements containing both
    vitamins and minerals and possibly other dietary supplements too.
- Adds/updates some `wikidata` properties.
@Freso
Freso force-pushed the freso/taxonomy/supplements branch from 57cc1e3 to 40e7353 Compare June 6, 2026 14:01
@sonarqubecloud

sonarqubecloud Bot commented Jun 6, 2026

Copy link
Copy Markdown

@aleene

aleene commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

looks good. This category needed some work

@Freso
Freso enabled auto-merge (squash) June 7, 2026 21:34

@stephanegigandet stephanegigandet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Freso
Freso merged commit 48d83fe into main Jun 17, 2026
39 checks passed
@github-project-automation github-project-automation Bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jun 17, 2026
@Freso
Freso deleted the freso/taxonomy/supplements branch June 17, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests vitamins

Projects

Development

Successfully merging this pull request may close these issues.

5 participants