Skip to content

fix: move admins to Config2.pm - #14245

Open
stephanegigandet wants to merge 6 commits into
mainfrom
admins
Open

fix: move admins to Config2.pm#14245
stephanegigandet wants to merge 6 commits into
mainfrom
admins

Conversation

@stephanegigandet

Copy link
Copy Markdown
Contributor

Changing admins should not require a git change.
One consequence is that admins may be different on each flavour. Which is ok I think.

@Freso Freso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple and reasonable to me. 👍 to making the admin-map a per-instance configuration too.

@github-project-automation github-project-automation Bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Aug 11, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
9156 7 9149 0
View the top 3 failed test(s) by shortest run time
tests_integration_create_pro_user_t::Test Plan Failure
Stack Traces | 16.7s run time
No plan was declared, and no assertions were made.
tests_integration_external_sources_t::Test Plan Failure
Stack Traces | 17.1s run time
No plan was declared, and no assertions were made.
tests_integration_api_v3_product_revert_t::Test Plan Failure
Stack Traces | 18.5s run time
No plan was declared, and no assertions were made.
tests_integration_protected_product_t::Test Plan Failure
Stack Traces | 18.9s run time
No plan was declared, and no assertions were made.
tests_integration_api_v3_product_images_upload_t::Test Plan Failure
Stack Traces | 19.3s run time
No plan was declared, and no assertions were made.
tests_integration_change_product_code_and_product_type_t::Test Plan Failure
Stack Traces | 19.6s run time
No plan was declared, and no assertions were made.
tests_integration_api_current_user_permissions_t::Test Plan Failure
Stack Traces | 39.2s run time
No plan was declared, and no assertions were made.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Freso

Freso commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

/update_tests_results

@teolemon teolemon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we document admins publicly somewhere, for each flavour, before we do this ?
  • Can we commit to keeping the documentation in sync with what's actually on the servers ?

@Freso

Freso commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator
  • Can we document admins publicly somewhere, for each flavour, before we do this ?
  • Can we commit to keeping the documentation in sync with what's actually on the servers ?

Could maybe make sense to have some automated list somewhere with this information? Similar to https://musicbrainz.org/privileged or https://en.wikipedia.org/w/index.php?title=Special:ListUsers&group=sysop or similar

@github-actions github-actions Bot added API WRITE WRITE API to allow sending product info and image 🧪 tests Account deletion Enabling users to delete account while preserving accountability for edits 👮 Moderation labels Aug 22, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Ready in 🛡️ Nutri-Patrol Aug 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Freso

Freso commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

/update_tests_results

%{clone(\%default_user_form)},
email => 'admin@openfoodfacts.org',
userid => 'stephane', # has to be part of %admins
userid => 'admin', # has to be part of %admins

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a Config.pm for the tests? Does the user need adding to %admins there too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Account deletion Enabling users to delete account while preserving accountability for edits API WRITE WRITE API to allow sending product info and image config 👮 Moderation 🧪 tests

Projects

Status: In Progress
Status: Ready

Development

Successfully merging this pull request may close these issues.

5 participants