fix: move admins to Config2.pm - #14245
Conversation
Freso
left a comment
There was a problem hiding this comment.
Seems simple and reasonable to me. 👍 to making the admin-map a per-instance configuration too.
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
/update_tests_results |
teolemon
left a comment
There was a problem hiding this comment.
- Can we document admins publicly somewhere, for each flavour, before we do this ?
- Can we commit to keeping the documentation in sync with what's actually on the servers ?
Could maybe make sense to have some automated list somewhere with this information? Similar to https://musicbrainz.org/privileged or https://en.wikipedia.org/w/index.php?title=Special:ListUsers&group=sysop or similar |
|
|
/update_tests_results |
| %{clone(\%default_user_form)}, | ||
| email => 'admin@openfoodfacts.org', | ||
| userid => 'stephane', # has to be part of %admins | ||
| userid => 'admin', # has to be part of %admins |
There was a problem hiding this comment.
Is there a Config.pm for the tests? Does the user need adding to %admins there too?



Changing admins should not require a git change.
One consequence is that admins may be different on each flavour. Which is ok I think.