fix: prompt for category before secondhand options - #14288
Draft
seanwessmith wants to merge 1 commit into
Draft
Conversation
seanwessmith
force-pushed
the
agent/hide-secondhand-without-category
branch
from
August 18, 2026 16:32
07c6b0a to
0a65af0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14288 +/- ##
==========================================
+ Coverage 50.28% 55.50% +5.22%
==========================================
Files 103 104 +1
Lines 26414 26477 +63
Branches 6319 6330 +11
==========================================
+ Hits 13282 14696 +1414
+ Misses 11371 9854 -1517
- Partials 1761 1927 +166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@seanwessmith the extra mile would be to add a nudge to add a category to get 2nd hand options. Something like "Add a category to discover 2nd hand options", using the Knowledge Panel Actions syntax present in other panels. |
seanwessmith
force-pushed
the
agent/hide-secondhand-without-category
branch
from
August 19, 2026 07:39
0a65af0 to
ac2ad2e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Add a categoryaction in the Secondhand card when a product has no categoriescategories_tagspaths with a regression testWhy
Donation and Used product links need a category to build a relevant search. The action explains why those options are unavailable and takes contributors directly to the Categories field.
Validation
make test-unit test=secondhand_knowledge_panels.tmake check_perltidy TO_CHECK='lib/ProductOpener/KnowledgePanels.pm tests/unit/secondhand_knowledge_panels.t'make check_critic TO_CHECK='lib/ProductOpener/KnowledgePanels.pm tests/unit/secondhand_knowledge_panels.t'make check_translationsgit diff --checkFixes #11110