Skip to content

feat: use Ciqual table 2025 version in addition to 2020 - #14306

Open
stephanegigandet wants to merge 18 commits into
mainfrom
ciqual-2025
Open

feat: use Ciqual table 2025 version in addition to 2020#14306
stephanegigandet wants to merge 18 commits into
mainfrom
ciqual-2025

Conversation

@stephanegigandet

Copy link
Copy Markdown
Contributor

We currently use the 2020 Ciqual table in Product Opener. There is an updated 2025 table.

This PR adds the 2025 table, and we still use the 2020 table as fallback. This is because some Ciqual codes from 2020 do not exist in the Ciqual table 2025.

Total entries in 2020: 3185
Total entries in 2025: 3484

Only in 2020: 182
Only in 2025: 481
In both versions: 3003

@stephanegigandet
stephanegigandet requested a review from a team as a code owner August 20, 2026 17:46
@github-project-automation github-project-automation Bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Aug 20, 2026
@github-actions github-actions Bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Aug 20, 2026
@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.40%. Comparing base (be295b4) to head (2a310f5).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/NutritionCiqual.pm 81.25% 1 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14306      +/-   ##
==========================================
+ Coverage   50.31%   54.40%   +4.09%     
==========================================
  Files         103      104       +1     
  Lines       26400    26475      +75     
  Branches     6316     6330      +14     
==========================================
+ Hits        13282    14403    +1121     
+ Misses      11357    10128    -1229     
- Partials     1761     1944     +183     
Flag Coverage Δ
integration-test-group-1 13.08% <0.00%> (?)
integration-test-group-2 9.20% <0.00%> (?)
integration-test-group-3 9.37% <0.00%> (?)
integration-test-group-5 28.82% <78.12%> (?)
integration-test-group-6 9.14% <0.00%> (?)
integration-test-group-7 9.62% <0.00%> (?)
integration-test-group-9 26.77% <78.12%> (?)
unit-test-group-1 25.07% <78.12%> (+0.05%) ⬆️
unit-test-group-2 31.32% <81.25%> (+0.04%) ⬆️
unit-test-group-3 33.62% <81.25%> (+0.04%) ⬆️
unit-test-group-4 22.34% <78.12%> (+0.04%) ⬆️
unit-test-group-5 28.34% <78.12%> (+0.03%) ⬆️
unit-test-group-6 21.56% <78.12%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stephanegigandet

Copy link
Copy Markdown
Contributor Author

/update_tests_results

@stephanegigandet stephanegigandet changed the title feat: use Ciqual table 2025 version in addition to 2020 - WIP feat: use Ciqual table 2025 version in addition to 2020 Aug 21, 2026
@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep both the source .xls and derived .csv’s around? If so, maybe we could store the .xls files in git-lfs storage rather than directly in the git repository itself? (The repository is already rather big even without adding (more) MB-size binary blobs to it…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests

Projects

Status: In progress
Status: To discuss and validate

Development

Successfully merging this pull request may close these issues.

4 participants