Skip to content

fix: render EAN barcodes with the correct format #14322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TaciteOFF merged 2 commits into from
Aug 23, 2026
Merged

fix: render EAN barcodes with the correct format #14322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d557730
fix: render EAN barcodes with the correct format
TaciteOFF Aug 22, 2026
c1107ae
fix: fall back to CODE128 when the EAN check digit is invalid
TaciteOFF Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions templates/web/pages/product/product_page.tt.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,31 @@ <h2 class="title-1" property="food:name" itemprop="name">[% title %]</h1>
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="[% IF code.length == 13 %]EAN13[% ELSIF code.length == 8 %]EAN8[% ELSE %]CODE128[% END %]"
jsbarcode-value="[% code %]"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="[% code %]" datatype="xsd:string"></div>
[% ELSE %]
[%# put in DOM for folksonomy %]
Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/page_crawler/crawler-access-product-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Only-Product – Nutell
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="0200000000235"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="0200000000235" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/page_crawler/normal-user-access-product-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Only-Product – Nutell
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="0200000000235"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="0200000000235" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/web_html/fr-product-2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Tarte aux pommes et aux
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="3300000000002"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="3300000000002" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/web_html/fr-product-raw-panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,14 +591,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Tarte aux pommes et aux
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="3300000000002"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="3300000000002" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/web_html/fr-product.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Apple pie – Bob's pie
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="3300000000001"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="3300000000001" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/web_html/world-product-content-only.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Apple pie – Bob's pie
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="3300000000001"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="3300000000001" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/web_html/world-product-smoothie.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Apple pie – Bob's pie
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="3300000000001"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="3300000000001" datatype="xsd:string"></div>


Expand Down
21 changes: 19 additions & 2 deletions tests/integration/expected_test_results/web_html/world-product.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,31 @@ <h2 class="title-1" property="food:name" itemprop="name">Apple pie – Bob's pie
<!-- Display with SVG if not mobile -->
<div id="barcode_div_svg">
<svg id="barcode_svg"
jsbarcode-format="auto"
jsbarcode-format="EAN13"
jsbarcode-value="3300000000001"
jsbarcode-displayValue="false"
jsbarcode-height="40">
</svg>
</div>
</div>
<script>if (screen && screen.width >= 600) JsBarcode("#barcode_svg").init()</script>
<script>
if (screen && screen.width >= 600) {
var barcodeSvg = document.getElementById("barcode_svg");
try {
JsBarcode(barcodeSvg).init();
}
catch (e) {
// JsBarcode refuses to render EAN13/EAN8 values with an invalid
// check digit (internal codes assigned by assign_new_code(), typos...),
// fall back to CODE128 so that the barcode is still displayed.
JsBarcode(barcodeSvg, barcodeSvg.getAttribute("jsbarcode-value"), {
format: "CODE128",
displayValue: false,
height: 40
});
}
}
</script>
<div property="gr:hasEAN_UCC-13" content="3300000000001" datatype="xsd:string"></div>


Expand Down
Loading