Skip to content

feat: make product query configuration init public#26

Open
Harry-KNIGHT wants to merge 3 commits intoopenfoodfacts:mainfrom
Harry-KNIGHT:patch-1
Open

feat: make product query configuration init public#26
Harry-KNIGHT wants to merge 3 commits intoopenfoodfacts:mainfrom
Harry-KNIGHT:patch-1

Conversation

@Harry-KNIGHT
Copy link
Copy Markdown

@Harry-KNIGHT Harry-KNIGHT commented Feb 27, 2025

What

  • Turn ProductQueryConfiguration init public & no more internal.

Fixes bug(s)

  • ProductQueryConfiguration' initializer is inaccessible due to 'internal' protection level

Part of

@teolemon teolemon requested a review from Copilot August 26, 2025 16:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the ProductQueryConfiguration initializer and related types publicly accessible by changing their access control from internal to public. The changes enable external consumers to create ProductQueryConfiguration instances and access related types that were previously restricted to internal use.

  • Change ProductQueryConfiguration.init from internal to public
  • Make ProductResponse properties, methods, and enum publicly accessible
  • Make ProductField enum public

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Sources/Model/OFF/ProductConfiguration.swift Makes the ProductQueryConfiguration initializer public
Sources/Model/OFF/ProductResponse.swift Makes ProductResponse properties, methods, constants, and CodingKeys enum public
Sources/Model/OFF/ProductField.swift Makes ProductField enum public

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@teolemon
Copy link
Copy Markdown
Member

@Harry-KNIGHT I'm no swift expert, so I will approve

@teolemon teolemon requested a review from a team August 26, 2025 16:52
@artem-alexandrov
Copy link
Copy Markdown

Can this one be merged please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants