fix(getImageUrl): strip trailing slash from assetsImagesPath to prevent double slashes#474
Open
roshinit-a wants to merge 2 commits intoopenfoodfacts:mainfrom
Open
Conversation
…nt double slashes Fixes openfoodfacts#473 getImageUrl() used a simple template literal that always added a '/' separator. If assetsImagesPath ended with '/', the result was a URL with double slashes (e.g. /assets//logo.png). Fix: apply .replace(/\/+$/, '') on the path before interpolation so one or more trailing slashes are stripped, regardless of how many were set. Also update app.test.ts: - Replace the old test that accepted the broken "/assets//image.png" output (which had a TODO comment acknowledging the bug) with a proper regression test that asserts the correct "/assets/image.png" - Add a test for multiple trailing slashes - Add a test for CDN URLs with trailing slashes
|
@roshinit-a is attempting to deploy a commit to the openfoodfacts Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getImageUrl()inweb-components/src/signals/app.tsproduces URLs with double slashes whenassetsImagesPathends with a trailing/(e.g. set by an integrating app viaassetsImagesPath.set("/assets/")).The bug was already acknowledged in
app.test.tswith the comment"// Double slash - might be a bug in implementation", but the test was accepting the broken output.Fix in
app.ts:Fix in
app.test.ts:/assets//image.png) with a proper regression test that asserts/assets/image.png/assets///)Screenshot or video
No visual changes — logic fix.
Related issue(s) and discussion
getImageUrl()produces double slashes whenassetsImagesPathhas a trailing slash #473Checklist: Author Self-Review
Large Language Models usage disclosure