feat: add OCR regex to detect Nutri-Score v2 through Nouveau calcul text#1878
Open
adiprathapa wants to merge 1 commit intoopenfoodfacts:mainfrom
Open
feat: add OCR regex to detect Nutri-Score v2 through Nouveau calcul text#1878adiprathapa wants to merge 1 commit intoopenfoodfacts:mainfrom
adiprathapa wants to merge 1 commit intoopenfoodfacts:mainfrom
Conversation
github-project-automation
Bot
moved this to To triage
in 🤖 Artificial Intelligence @ Open Food Facts
github-project-automation
Bot
added this to 🤖 Artificial Intelligence @ Open Food Facts
adiprathapa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new OCR based regex predictor to differentiate between the old and new Nutri-Score (v2) logos. Right now the visual similarity causes some false positives, so I implemented a text matching layer that looks for Nouveau calcul and its translations.
Main Changes
en:nutriscore-v2for now. I noticed the taxonomy has specific tags likeen:nutriscore-grade-a-new-calculation, but because this is a general detection for the version of the algorithm, a generic v2 tag is what I went with. Please lmk any suggestions on the naming convention.Should Fix #1346
Test Plan
I expanded the suite with 15 new test cases to verify correct detection across all 11 languages, case insensitivity, compatibility with existing
en:nutriscoredetection to make sure it isn't breaking current logic. All 24 label tests are passing locally.