fix(api): return proper search error status codes#376
Open
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Open
fix(api): return proper search error status codes#376SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refines Search API error handling so known client-side query errors return 400, Elasticsearch availability errors return 503, and unknown errors continue to return 500.
Related issue
What changed
search.pyapi.pytest_api.pycovering:400 Bad Request503 Service Unavailable500 Internal Server ErrorBehavior
Before
500After
400503500Why this is needed
Testing Done
Backend unit tests
45 passedBackend integration tests
73 passed3 xfailedFrontend tests