refactor(frontend): add explicit facet types for search result signal#389
Open
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Open
refactor(frontend): add explicit facet types for search result signal#389SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces shared explicit interfaces for search result facets and charts, replacing weak
Objecttyping inSearchResultDetail.It aligns facet-related types across shared signal state and facet component implementations, improving maintainability and type safety without changing runtime behavior.
Related Issue
Fixes #388
What Changed
Objecttyping inSearchResultDetailAffected Files
signals.tssearch-facets.tssearch-result-interfaces.tsTesting
Full local gate executed successfully:
Notes
This is a frontend refactor focused on stronger typing and maintainability with no functional behavior changes.