refactor(frontend): split SearchaliciousSearchMixin into smaller mixins#398
Open
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Open
refactor(frontend): split SearchaliciousSearchMixin into smaller mixins#398SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Conversation
Decoupled the monolithic frontend search controller mixin into: - SearchaliciousStateMixin: handles state, properties and signal updates - SearchaliciousDomMixin: handles DOM querying (facets, charts, sorts) - SearchaliciousApiMixin: handles search API fetching and params building Composed them back in search-ctl.ts. Validated with TypeScript build and passing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses technical debt in the frontend search controller by splitting the monolithic
SearchaliciousSearchMixininto smaller, logically separated mixins.The refactor improves separation of concerns by isolating state management, DOM interactions, and API handling, while preserving the existing external behavior and controller composition.
Related Issue
Fixes #397
What Changed
Extracted State Management
Created
search-ctl-state.tscontainingSearchaliciousStateMixin, responsible for:@propertydecorators@statedecoratorsExtracted DOM Interactions
Created
search-ctl-dom.tscontainingSearchaliciousDomMixin, responsible for:Extracted API Handling
Created
search-ctl-api.tscontainingSearchaliciousApiMixin, responsible for:search()request flowRecomposed Controller
Updated
search-ctl.tsto compose the new mixins in sequence:Affected Files
search-ctl.tssearch-ctl-state.tssearch-ctl-dom.tssearch-ctl-api.tsTesting
Verification gateway executed successfully:
Notes
This is a structural frontend refactor focused on maintainability, readability, and cleaner separation of concerns with no intended runtime behavior changes.