feat(backend): introduce bounded lru_cache and observability to query#402
Open
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Open
feat(backend): introduce bounded lru_cache and observability to query#402SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
SaitejaKommi wants to merge 1 commit intoopenfoodfacts:mainfrom
Conversation
…-builder Replaced unbounded dict caches in app/search.py with @functools.lru_cache(maxsize=32). Added config_version parameter to automatically trigger cache invalidation upon configuration reloads. Exposed cache info dict securely via the /health endpoint and internal debug log statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes query-builder caching in
search.pyby replacing manually maintained unbounded dictionaries with bounded nativelru_cachestrategies.It introduces automatic config-aware cache invalidation and exposes runtime cache metrics for observability, improving memory safety, maintainability, and operational tuning.
Related Issue
Fixes #401
What Changed
Refactored Cache Engine
Removed manually managed in-memory cache dictionaries:
_ES_QUERY_BUILDERS_RESULT_PROCESSORSIntroduced Bounded Caching
Wrapped query-builder / processor factories using:
@functools.lru_cache(maxsize=32)Benefits include:
Config-Aware Invalidation
Bound cache keys to a configuration identity/version parameter using:
When the active config object reloads, the new identity naturally causes cache misses and rebuilds fresh entries.
Added Observability Hooks
Exposed runtime cache metrics via:
Surfaced values include:
These metrics are now available through health diagnostics, enabling live tuning and monitoring.
Improved Debug Visibility
Added debug logging around Elasticsearch translation / cache evaluation paths.
Affected Files
search.pyhealth.pyTesting
Verification gateway executed successfully:
Notes
This is a backend performance and observability enhancement with no intended API behavior changes.