fix: top bar search resets state instead of refining#417
Open
saivats wants to merge 4 commits into
Open
Conversation
Author
|
@alexgarel @teolemon — fix for #306 is ready for review. |
alexgarel
reviewed
Jun 2, 2026
Member
|
@saivats great, I'll validate my suggestion, it's better to have more comments! But I will then validate |
alexgarel
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
search instead of combining with the previous search state.
Root cause
In
submitSuggestion()insearch-bar.ts, the non-suggestion path(plain text + Enter) only set
this.queryand calledthis.search().But
buildParams()was still including old facet filters via_facetsFilters(), appending them to the new query and causing thecombined search and backend 500 error.
Fix
Added
this.resetFacets(false)before setting the new query in theelsebranch ofsubmitSuggestion(). This reuses the existingresetFacets()method already used by the Reset button.Testing
search-bar_test.tsverifyingresetFacetsiscalled when user submits plain text search
now returns only pasta results