feat: Deeplinking for the forgot password page #5362

jnnabugwu · 2024-06-12T20:52:13Z

What

Added deep linking for the forgot password page.

can be tested at https://world.openfoodfacts.org/forgot-password/

Screenshot

Screen.Recording.2024-06-12.at.4.41.26.PM.mov

Fixes bug(s)

Fixes:

Part of

🎯 What can I work on ? (mobile app) #525

…bugwu/smooth-app into deeplinking-forgot-password

g123k · 2024-06-13T06:37:55Z

You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362

Running dart format . should fix this

jnnabugwu · 2024-07-01T23:27:41Z

You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362

Running dart format . should fix this

Sorry, I missed this. I will fix this

g123k · 2024-07-02T10:30:15Z

You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362
Running dart format . should fix this

Sorry, I missed this. I will fix this

It seems your commit partially fixes the issue.
Just run the command, it should be fine.

codecov-commenter · 2024-07-02T16:45:38Z

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 5.89%. Comparing base (4d9c7fc) to head (edc26bf).
Report is 799 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../smooth_app/lib/pages/navigator/app_navigator.dart	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5362      +/-   ##
==========================================
- Coverage     9.54%   5.89%   -3.66%     
==========================================
  Files          325     493     +168     
  Lines        16411   29458   +13047     
==========================================
+ Hits          1567    1737     +170     
- Misses       14844   27721   +12877

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

g123k · 2024-07-04T06:58:45Z

Thanks for the fix.
What happens when you click on the back button on top? (left arrow)

jnnabugwu · 2024-07-04T22:48:19Z

Thanks for the fix. What happens when you click on the back button on top? (left arrow)

Let me check

jnnabugwu · 2024-07-06T17:45:54Z

[

Screen.Recording.2024-07-06.at.1.39.36.PM.mov

](url)

It goes back to the home page

M123-dev · 2024-07-29T07:36:02Z

@g123k

g123k · 2024-07-29T12:29:29Z

packages/smooth_app/lib/pages/navigator/app_navigator.dart

@@ -282,6 +287,8 @@ class _SmoothGoRouter {
            }
          } else if (path == _ExternalRoutes.MOBILE_APP_DOWNLOAD) {
            return AppRoutes.HOME;
+          } else if (path == _ExternalRoutes.FORGOT_PASSWORD) {


Could you move this statement before or after SIGNUP?
It will allow the regrouping of user management routes.
Thanks

Okay will do

M123-dev · 2024-10-07T16:17:46Z

Heyy, there are some conflicts, but they seem to be just a few lines.
Is planned to continue this PR

jnnabugwu · 2024-11-04T23:25:01Z

Yeah ill have this cleaned up this week really by tomorrow

github-throwaway · 2025-02-16T13:29:25Z

@jnnabugwu are you still working on this? :)

jnnabugwu · 2025-02-18T02:01:46Z

@g123k This is ready to be merged are there any other changes needed?

github-throwaway · 2025-02-18T05:57:12Z

@jnnabugwu this PR does not pass the required checks yet. Take a look why:

2025-02-18T02:00:29.5012047Z ##[group]Run flutter analyze --fatal-infos --fatal-warnings .
2025-02-18T02:00:29.5012494Z �[36;1mflutter analyze --fatal-infos --fatal-warnings .�[0m
2025-02-18T02:00:29.5067372Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-02-18T02:00:29.5067709Z env:
2025-02-18T02:00:29.5067966Z   FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.27.2-x64
2025-02-18T02:00:29.5068307Z   PUB_CACHE: /home/runner/.pub-cache
2025-02-18T02:00:29.5068560Z ##[endgroup]
2025-02-18T02:01:06.8747873Z Analyzing smooth-app...                                         
2025-02-18T02:01:06.8754107Z 
2025-02-18T02:01:06.8792631Z   error • Target of URI doesn't exist: 'package:smooth_app/pages/scan/search_page.dart' • packages/smooth_app/lib/pages/navigator/app_navigator.dart:26:8 • uri_does_not_exist
2025-02-18T02:01:06.8795112Z   error • Target of URI doesn't exist: 'package:smooth_app/pages/scan/search_product_helper.dart' • packages/smooth_app/lib/pages/navigator/app_navigator.dart:27:8 • uri_does_not_exist
2025-02-18T02:01:06.8801414Z    info • Sort directive sections alphabetically • packages/smooth_app/lib/pages/navigator/app_navigator.dart:29:1 • directives_ordering
2025-02-18T02:01:06.8804927Z 
2025-02-18T02:01:06.8968445Z 3 issues found. (ran in 36.9s)
2025-02-18T02:01:06.9074790Z ##[error]Process completed with exit code 1.

jnnabugwu · 2025-02-26T18:26:45Z

@jnnabugwu this PR does not pass the required checks yet. Take a look why:

2025-02-18T02:00:29.5012047Z ##[group]Run flutter analyze --fatal-infos --fatal-warnings .
2025-02-18T02:00:29.5012494Z �[36;1mflutter analyze --fatal-infos --fatal-warnings .�[0m
2025-02-18T02:00:29.5067372Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-02-18T02:00:29.5067709Z env:
2025-02-18T02:00:29.5067966Z   FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.27.2-x64
2025-02-18T02:00:29.5068307Z   PUB_CACHE: /home/runner/.pub-cache
2025-02-18T02:00:29.5068560Z ##[endgroup]
2025-02-18T02:01:06.8747873Z Analyzing smooth-app...                                         
2025-02-18T02:01:06.8754107Z 
2025-02-18T02:01:06.8792631Z   error • Target of URI doesn't exist: 'package:smooth_app/pages/scan/search_page.dart' • packages/smooth_app/lib/pages/navigator/app_navigator.dart:26:8 • uri_does_not_exist
2025-02-18T02:01:06.8795112Z   error • Target of URI doesn't exist: 'package:smooth_app/pages/scan/search_product_helper.dart' • packages/smooth_app/lib/pages/navigator/app_navigator.dart:27:8 • uri_does_not_exist
2025-02-18T02:01:06.8801414Z    info • Sort directive sections alphabetically • packages/smooth_app/lib/pages/navigator/app_navigator.dart:29:1 • directives_ordering
2025-02-18T02:01:06.8804927Z 
2025-02-18T02:01:06.8968445Z 3 issues found. (ran in 36.9s)
2025-02-18T02:01:06.9074790Z ##[error]Process completed with exit code 1.

Will have this done by next week

github-throwaway · 2025-03-12T23:05:36Z

@jnnabugwu should we close this PR? Or are you still working on it?

jnnabugwu · 2025-03-12T23:22:51Z

@jnnabugwu should we close this PR? Or are you still working on it?

let me do this now!

…bugwu/smooth-app into deeplinking-forgot-password

jnnabugwu · 2025-03-12T23:41:04Z

@g123k Can you look at this pr again sorry for the long wait and thanks for the patience.

teolemon · 2025-04-27T09:31:46Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces deep linking for the forgot password page, enhancing the user experience by allowing direct access to the password reset functionality from external links. The changes appear well-structured and integrate smoothly with the existing navigation system. However, there are a few points that could be improved to enhance code clarity and maintainability.

Summary of Findings

Route Definition Consistency: The naming and structure of internal routes should be consistent across the application to improve maintainability and reduce potential errors. Ensure that the naming convention for routes like FORGOT_PASSWORD_PAGE aligns with other similar routes.
External Route Handling: When adding new external routes, it's important to consider all potential use cases and ensure that the application handles them gracefully. Verify that the new FORGOT_PASSWORD external route is correctly processed and redirects users as expected.
Code Comment Completeness: Ensure that all code additions, especially those related to routing and navigation, are adequately commented to explain their purpose and functionality. This helps in maintaining code clarity and facilitates future modifications.

Merge Readiness

The pull request is almost ready for merging. Addressing the identified issues related to route definition consistency, external route handling, and code comment completeness will further enhance the quality and maintainability of the code. I am unable to approve this pull request, and recommend that another reviewer approves this code before merging.

jnnabugwu added 4 commits June 5, 2024 20:09

feat: added deeplinking to forgot password page

09a48cd

Merge branch 'deeplinking-forgot-password' of https://github.com/jnna…

89737bf

…bugwu/smooth-app into deeplinking-forgot-password

fix: fix merge conflicts

8f528a3

Merge branch 'openfoodfacts:develop' into deeplinking-forgot-password

4e1912d

jnnabugwu requested a review from a team as a code owner June 12, 2024 20:52

github-actions bot assigned jnnabugwu Jun 12, 2024

g123k changed the title ~~Deeplinking forgot password~~ feat: Deeplinking forgot password Jun 13, 2024

teolemon added the 🔐 Password reset label Jun 14, 2024

fix: formatted app navigator page

07d5511

fix: organized imports

29973d2

g123k requested changes Jul 29, 2024

View reviewed changes

Merge branch 'openfoodfacts:develop' into deeplinking-forgot-password

503eda8

teolemon added the ✨ enhancement New feature or request label Aug 1, 2024

teolemon changed the title ~~feat: Deeplinking forgot password~~ feat: Deeplinking for the forgot password page Aug 1, 2024

teolemon added the 🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps label Aug 1, 2024

Merge branch 'develop' into deeplinking-forgot-password

a603218

github-actions bot added the PR: needs rebase label Aug 7, 2024

fix: moving forgot_password after signup

f357c8e

github-actions bot added the router label Nov 6, 2024

Merge branch 'develop' into deeplinking-forgot-password

68f557f

github-actions bot removed the PR: needs rebase label Nov 6, 2024

jnnabugwu requested a review from g123k November 6, 2024 19:45

Merge branch 'develop' into deeplinking-forgot-password

6a40dd9

Merge branch 'develop' into deeplinking-forgot-password

1397d6f

jnnabugwu added 3 commits March 12, 2025 18:31

Merge branch 'develop' into deeplinking-forgot-password

63be49d

chore: fix imports

9c4ef18

Merge branch 'deeplinking-forgot-password' of https://github.com/jnna…

edc26bf

…bugwu/smooth-app into deeplinking-forgot-password

github-throwaway requested review from g123k and removed request for g123k March 13, 2025 05:52

teolemon requested a review from Copilot April 19, 2025 14:18

This comment was marked as resolved.

Sign in to view

gemini-code-assist bot reviewed Apr 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Deeplinking for the forgot password page #5362

feat: Deeplinking for the forgot password page #5362

jnnabugwu commented Jun 12, 2024

g123k commented Jun 13, 2024 •

edited by M123-dev

Loading

jnnabugwu commented Jul 1, 2024

g123k commented Jul 2, 2024

codecov-commenter commented Jul 2, 2024 •

edited

Loading

g123k commented Jul 4, 2024

jnnabugwu commented Jul 4, 2024

jnnabugwu commented Jul 6, 2024

M123-dev commented Jul 29, 2024

g123k Jul 29, 2024

jnnabugwu Aug 5, 2024

M123-dev commented Oct 7, 2024

jnnabugwu commented Nov 4, 2024

github-throwaway commented Feb 16, 2025

jnnabugwu commented Feb 18, 2025

github-throwaway commented Feb 18, 2025

jnnabugwu commented Feb 26, 2025

github-throwaway commented Mar 12, 2025

jnnabugwu commented Mar 12, 2025

jnnabugwu commented Mar 12, 2025

This comment was marked as resolved.

teolemon commented Apr 27, 2025

gemini-code-assist bot left a comment

feat: Deeplinking for the forgot password page #5362

Are you sure you want to change the base?

feat: Deeplinking for the forgot password page #5362

Conversation

jnnabugwu commented Jun 12, 2024

What

Screenshot

Fixes bug(s)

Part of

g123k commented Jun 13, 2024 • edited by M123-dev Loading

jnnabugwu commented Jul 1, 2024

g123k commented Jul 2, 2024

codecov-commenter commented Jul 2, 2024 • edited Loading

Codecov Report

g123k commented Jul 4, 2024

jnnabugwu commented Jul 4, 2024

jnnabugwu commented Jul 6, 2024

M123-dev commented Jul 29, 2024

g123k Jul 29, 2024

Choose a reason for hiding this comment

jnnabugwu Aug 5, 2024

Choose a reason for hiding this comment

M123-dev commented Oct 7, 2024

jnnabugwu commented Nov 4, 2024

github-throwaway commented Feb 16, 2025

jnnabugwu commented Feb 18, 2025

github-throwaway commented Feb 18, 2025

jnnabugwu commented Feb 26, 2025

github-throwaway commented Mar 12, 2025

jnnabugwu commented Mar 12, 2025

jnnabugwu commented Mar 12, 2025

This comment was marked as resolved.

teolemon commented Apr 27, 2025

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Summary of Findings

Merge Readiness

g123k commented Jun 13, 2024 •

edited by M123-dev

Loading

codecov-commenter commented Jul 2, 2024 •

edited

Loading