feat: Add receipt and price icons to prices screen #6421

vinay769 · 2025-03-06T20:16:30Z

What

Added receipt and price icons to the price page to improve visual clarity and user understanding.
Change the RadioListTile Widget to Radio widget to show the icon of receipt and price tag

feat, for Features enhancing User Experience and User Interface

Screenshot

Part of

🎯 What can I work on ? (mobile app) #525 in this what i put in discription here i made changes of putting icons for recepit and prices tag in price page and a screenshot atached

teolemon · 2025-03-07T18:08:06Z

@vinay769 Run dart format --set-exit-if-changed .
Formatted packages/smooth_app/lib/pages/prices/price_proof_card.dart
Formatted 567 files (1 changed) in 1.88 seconds.
Error: Process completed with exit code 1.

vinay769 · 2025-03-08T18:11:31Z

hello @teolemon Ran dart format command and can you please review thanks

AshAman999

Hey @vinay769

Left some comments

packages/smooth_app/lib/pages/prices/price_proof_card.dart

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

packages/smooth_app/pubspec.lock

codecov-commenter · 2025-03-10T12:19:39Z

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 5.84%. Comparing base (4d9c7fc) to head (b5ef09c).
Report is 800 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../smooth_app/lib/pages/prices/price_proof_card.dart	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6421      +/-   ##
==========================================
- Coverage     9.54%   5.84%   -3.71%     
==========================================
  Files          325     490     +165     
  Lines        16411   29259   +12848     
==========================================
+ Hits          1567    1711     +144     
- Misses       14844   27548   +12704

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…t.swift

vinay769 · 2025-03-10T18:30:56Z

done with this thanks to @AshAman999 @teolemon please take a look

monsieurtanuki

Hi @vinay769!

There are conflicts to be fixed, because of recent changes in the master branch.
You should add your IconData in ProofTypeExtension.

I'm very worried about the UI.
You're lucky because your screenshots are in English, with small words.
Would you please try with different longer labels? I suggest "Ticket de caisse" and "Etiquette de prix".

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

vinay769 · 2025-03-13T10:54:45Z

Okay thanks for you valuable feedback @monsieurtanuki i was working on this and get back to you ASAP with great solution

vinay769 · 2025-03-15T18:33:54Z

hello @monsieurtanuki @teolemon

is it okay to put icon after text
is i have a permission to change the font size to fit the text in one line

if both the above answer is yes then the UI is ready to merge
please help me with this
thank you

monsieurtanuki · 2025-03-15T19:30:59Z

Hi @vinay769!
I'm not a big fan of the UI.
Would you try with 2 rows of radio buttons, instead of 2 columns? Please post the screenshots.

vinay769 · 2025-03-16T07:42:45Z

hello @monsieurtanuki

Would you kindly review the following code and provide feedback for optimization?

monsieurtanuki

Hi @vinay769!
Please have a look at my comments.

Would you try with 2 rows of radio buttons, instead of 2 columns? Please post the screenshots.

In case my demand is not explicit enough given the polysemous concepts of rows and columns (especially in flutter), let me draw what I intended.
* Column 1 | * Column 2
and
* Row 1 _______________
* Row 2 _______________

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

packages/smooth_app/lib/pages/prices/proof_type_extensions.dart

monsieurtanuki · 2025-03-16T11:52:18Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

-                      child: RadioListTile<ProofType>(
-                        title: Text(item.getTitle(appLocalizations)),
-                        value: item,
+              children: <Widget>[


You've rolled back the previous code.
Please stick to the previous code unless you have a good reason. Duplicating code is not a good reason.

monsieurtanuki · 2025-03-16T11:55:12Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

-    final BuildContext context, {
-    required final List<_ProofSource> sources,
-  }) async {
+  static Future<_ProofSource?> select(final BuildContext context) async {


Please stick to the previous code (especially as you've removed bug fixes).
Besides, _ProofSource has nothing to do with the current PR, therefore I wouldn't expect reviewing that code.
Unless there's a good reason.

g123k · 2025-03-17T15:45:36Z

Hello @vinay769,

You can use the following layout:

The toggle is now on top of the screen
For the custom icons, I will add them later (or edit your PR)

This component will be used elsewhere in the app, so don't hesitate to make it generic.
It doesn't necessarily rely on an existing Widget in the Material and Cupertino libs.

vinay769 · 2025-03-18T09:41:39Z

Hello @vinay769,

You can use the following layout:

The toggle is now on top of the screen

For the custom icons, I will add them later (or edit your PR)

This component will be used elsewhere in the app, so don't hesitate to make it generic.
It doesn't necessarily rely on an existing Widget in the Material and Cupertino libs.

Thanks @g123k for this.

…wift

g123k · 2025-04-14T07:32:26Z

Any update on this?
If you can't work on this PR, please let us know.

vinay769 · 2025-04-14T07:59:14Z

Hello @g123k,
I am currently not working on this issue. Please feel free to assign it to someone else who is interested in resolving it.
Thank you!

teolemon · 2025-05-16T19:37:32Z

/gemini review

gemini-code-assist

Code Review

This pull request successfully adds icons to the price page for ProofType.receipt and ProofType.priceTag, enhancing visual clarity as intended. The change from RadioListTile to Radio widgets facilitates this.

However, there are critical concerns regarding file deletions:

pubspec.lock Deletion: This file is essential for reproducible builds as it locks dependency versions. Deleting it can lead to inconsistent builds and unexpected behavior. This file must be restored to its state before this PR's changes, or regenerated correctly if dependencies were intentionally updated (though no such changes are evident in pubspec.yaml in this PR).
GeneratedPluginRegistrant.swift Deletion: This file is typically auto-generated and crucial for macOS plugin registration. Its deletion might break macOS builds or functionality if macOS support is intended. Please clarify if this deletion was intentional and provide context, or restore the file.

Additionally, there are a few areas with potential unintended behavioral changes and opportunities for code improvement, detailed in the specific comments. Due to the critical file deletions and potential behavioral changes, I recommend addressing these issues before merging.

Summary of Findings

Critical File Deletion: pubspec.lock: The pubspec.lock file has been deleted. This file is crucial for reproducible builds and should be restored or correctly regenerated.
Critical File Deletion: GeneratedPluginRegistrant.swift: The GeneratedPluginRegistrant.swift file for macOS has been deleted. This could break macOS builds/functionality and needs clarification or restoration.
Potential Behavioral Change: forcedProofType: The forcedProofType condition is no longer used to disable the onChanged callback for proof type radio buttons in price_proof_card.dart. This might be an unintended behavioral change if forcedProofType was meant to make the selection read-only. (Commented)
Code Duplication in UI: The UI for ProofType.receipt and ProofType.priceTag radio options in price_proof_card.dart is duplicated. Refactoring into a helper method is recommended. (Commented)
Potential Behavioral Change: includeMyProofs: The _ProofSource.select method in price_proof_card.dart now seems to always include the 'history' option, whereas previously this was conditional based on includeMyProofs. This could be an intended simplification or an oversight. (Commented)
TODOs in ProofTypeExtension.getIcon(): The new getIcon() method in proof_type_extensions.dart has TODO comments and throws UnimplementedError for ProofType.gdprRequest and ProofType.shopImport. While this might be acceptable if these types are not currently used in this UI context, it's good to plan for their handling if they might appear. (Not commented due to severity settings)

Merge Readiness

This pull request should not be merged in its current state due to the critical deletion of pubspec.lock and GeneratedPluginRegistrant.swift. These file changes need immediate attention and likely reversal or justification.

Additionally, there are potential behavioral changes related to forcedProofType and includeMyProofs that need clarification to ensure no regressions are introduced. The identified code duplication should also be addressed for better maintainability.

Once these critical and high-priority issues are resolved, the PR will be in a much better state for merging. I am unable to approve pull requests, but I recommend further review after these changes are made.

gemini-code-assist · 2025-05-16T19:38:59Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

+                        onChanged: model.proof != null
+                            ? null
+                            : (final ProofType? proofType) =>
+                                model.proofType = proofType!,


It appears the forcedProofType condition is no longer used to disable the onChanged callback for the radio buttons. Previously, if forcedProofType != null, the RadioListTile was disabled. Now, the Radio widget's onChanged is only disabled if model.proof != null.

Was it intentional to remove the disabling effect of forcedProofType? If forcedProofType is meant to make the proof type selection non-editable, this change could introduce a regression.

gemini-code-assist · 2025-05-16T19:38:59Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

+              children: <Widget>[
+                SizedBox(
+                  width: constraints.maxWidth / 2,
+                  child: Row(
+                    children: [
+                      Radio<ProofType>(
+                        value: ProofType.receipt,
                        groupValue: model.proofType,
-                        onChanged:
-                            model.proof != null || forcedProofType != null
-                                ? null
-                                : (final ProofType? proofType) =>
-                                    model.proofType = proofType!,
+                        onChanged: model.proof != null
+                            ? null
+                            : (final ProofType? proofType) =>
+                                model.proofType = proofType!,
                      ),
-                    ),
-                  )
-                  .toList(),
+                      Icon(ProofType.receipt.getIcon()),
+                      const SizedBox(width: 8),
+                      Expanded(
+                        child: Text(
+                          appLocalizations.prices_proof_receipt,
+                          maxLines: 2,
+                        ),
+                      ),
+                    ],
+                  ),
+                ),
+                SizedBox(
+                  width: constraints.maxWidth / 2,
+                  child: Row(
+                    children: [
+                      Radio<ProofType>(
+                        value: ProofType.priceTag,
+                        groupValue: model.proofType,
+                        onChanged: model.proof != null
+                            ? null
+                            : (final ProofType? proofType) =>
+                                model.proofType = proofType!,
+                      ),
+                      Icon(ProofType.priceTag.getIcon()),
+                      const SizedBox(width: 8),
+                      Expanded(
+                        child: Text(
+                          appLocalizations.prices_proof_price_tag,
+                          maxLines: 2,
+                        ),
+                      ),
+                    ],
+                  ),
+                ),
+              ],


The UI structure for displaying the ProofType.receipt radio option (lines 101-123) and the ProofType.priceTag radio option (lines 124-146) is nearly identical. This introduces code duplication.

Could we consider refactoring this into a reusable widget or a helper method? For example, a method like Widget _buildProofTypeRadioOption(BuildContext context, ProofType proofType, BoxConstraints constraints, PriceModel model) could encapsulate the common logic, making the code more concise and maintainable.

gemini-code-assist · 2025-05-16T19:38:59Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

+                      final _ProofSource? proofSource =
+                          await _ProofSource.select(context);


The logic for selecting a _ProofSource has been simplified. Previously, _ProofSource.getPossibleProofSources (which accepted an includeMyProofs parameter) was used to determine the available sources. This method has been removed (Diff 4), and _ProofSource.select now seems to always include _ProofSource.history as an option.

If includeMyProofs was previously false in some scenarios, this would mean the 'history' option wasn't available. Is it intended for the 'history' option to always be present now, regardless of the context where includeMyProofs might have been used?

Copilot

Pull Request Overview

This PR enhances the prices screen by adding distinct receipt and price-tag icons and refactors the proof-type selection UI.

Introduces a getIcon() extension for ProofType to provide corresponding icons
Replaces RadioListTile with a custom Radio + Icon + Text layout
Simplifies the proof-source selection modal by removing the includeMyProofs parameter

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift	Deleted auto-generated plugin registrant (likely unintended)
packages/smooth_app/lib/pages/prices/proof_type_extensions.dart	Imported Material and added `getIcon()` extension for `ProofType`
packages/smooth_app/lib/pages/prices/price_proof_card.dart	Updated UI to use `Radio` widgets with icons and simplified selection logic

Comments suppressed due to low confidence (2)

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift:1

Removing the entire GeneratedPluginRegistrant.swift may break macOS plugin registration, as this file is auto-generated and should not be manually deleted.

-//

packages/smooth_app/lib/pages/prices/price_proof_card.dart:87

The selection now always shows all proof sources and ignores the original includeMyProofs flag, altering intended behavior when includeMyProofs is false.

                      final _ProofSource? proofSource = await _ProofSource.select(context);

Copilot · 2025-05-16T19:39:00Z

packages/smooth_app/lib/pages/prices/proof_type_extensions.dart

+        // TODO: Handle this case.
+        ProofType.gdprRequest => throw UnimplementedError(),
+        // TODO: Handle this case.
+        ProofType.shopImport => throw UnimplementedError(),


[nitpick] The getIcon() method throws UnimplementedError for gdprRequest and shopImport, potentially causing runtime crashes. Consider handling or documenting these cases.

Suggested change

// TODO: Handle this case.

ProofType.gdprRequest => throw UnimplementedError(),

// TODO: Handle this case.

ProofType.shopImport => throw UnimplementedError(),

ProofType.gdprRequest => Icons.privacy_tip, // Placeholder icon for GDPR Request

ProofType.shopImport => Icons.store, // Placeholder icon for Shop Import

Copilot · 2025-05-16T19:39:01Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

      addEndArrowToItems: true,
-      values: sources,
+      values: <_ProofSource>[
+        _ProofSource.camera,


The values list always includes camera, but the labels and prefixIcons lists conditionally omit it when hasCamera is false, causing misalignment between labels, icons, and values.

Suggested change

_ProofSource.camera,

if (hasCamera) _ProofSource.camera,

Copilot · 2025-05-16T19:39:01Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

+                  child: Row(
+                    children: [
+                      Radio<ProofType>(
+                        value: ProofType.receipt,
                        groupValue: model.proofType,
-                        onChanged:
-                            model.proof != null || forcedProofType != null
-                                ? null
-                                : (final ProofType? proofType) =>
-                                    model.proofType = proofType!,
+                        onChanged: model.proof != null
+                            ? null
+                            : (final ProofType? proofType) =>
+                                model.proofType = proofType!,
                      ),
-                    ),
-                  )
-                  .toList(),
+                      Icon(ProofType.receipt.getIcon()),
+                      const SizedBox(width: 8),
+                      Expanded(
+                        child: Text(
+                          appLocalizations.prices_proof_receipt,
+                          maxLines: 2,
+                        ),
+                      ),
+                    ],
+                  ),
+                ),
+                SizedBox(
+                  width: constraints.maxWidth / 2,
+                  child: Row(
+                    children: [
+                      Radio<ProofType>(
+                        value: ProofType.priceTag,
+                        groupValue: model.proofType,
+                        onChanged: model.proof != null
+                            ? null
+                            : (final ProofType? proofType) =>
+                                model.proofType = proofType!,
+                      ),
+                      Icon(ProofType.priceTag.getIcon()),
+                      const SizedBox(width: 8),
+                      Expanded(
+                        child: Text(
+                          appLocalizations.prices_proof_price_tag,
+                          maxLines: 2,
+                        ),
+                      ),
+                    ],


[nitpick] The layout for Receipt and PriceTag is duplicated. Consider abstracting common logic (e.g., iterating over a list of types) to reduce repetition and ease future updates.

g123k · 2025-06-09T06:30:52Z

There is no activity on this PR.
Also, we will revamp this screen, so I close this issue.

Thanks for this contribution @vinay769

feat: Add receipt and price icons to prices screen

eedb630

github-project-automation bot added this to 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 6, 2025

github-project-automation bot moved this to 💬 To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 6, 2025

github-actions bot assigned vinay769 Mar 6, 2025

github-actions bot added Prices 🖥️ MacOS labels Mar 6, 2025

github-project-automation bot added this to 💸 Open Prices Mar 6, 2025

github-project-automation bot moved this to Backlog in 💸 Open Prices Mar 6, 2025

vinay769 mentioned this pull request Mar 7, 2025

Add receipt and price tag icons #5904

Open

teolemon linked an issue Mar 7, 2025 that may be closed by this pull request

Add receipt and price tag icons #5904

Open

vinay769 added 4 commits March 8, 2025 22:53

Merge branch 'develop' into feature/receipt-price-icons-ui

db1f5ec

style: Format code to pass CI/CD formatting check

9df5045

style: Format code to pass CI/CD formatting check

9804cd2

style: Format code to pass CI/CD formatting check

3caf9ef

github-actions bot added the PR: needs rebase label Mar 9, 2025

AshAman999 reviewed Mar 9, 2025

View reviewed changes

chore: Remove comments, revert pubspec.lock, GeneratedPluginRegistran…

b5ef09c

…t.swift

github-actions bot removed the PR: needs rebase label Mar 10, 2025

teolemon requested review from g123k, monsieurtanuki and AshAman999 March 13, 2025 09:35

github-actions bot added the PR: needs rebase label Mar 13, 2025

monsieurtanuki reviewed Mar 13, 2025

View reviewed changes

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift Outdated Show resolved Hide resolved

vinay769 added 2 commits March 14, 2025 00:27

Merge origin/develop: Integrate latest develop changes

390257b

updating the price_proof_card

5fa1dc4

feat: Add receipt and price tag icons, support long labels

fb61397

github-actions bot removed the PR: needs rebase label Mar 16, 2025

monsieurtanuki reviewed Mar 16, 2025

View reviewed changes

vinay769 added 2 commits April 7, 2025 12:30

removed packages/smooth_app/pubspec.lock

26fe393

removed packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.s…

8706ee5

…wift

github-actions bot added the PR: needs rebase label Apr 7, 2025

g123k marked this pull request as draft April 17, 2025 05:55

teolemon requested a review from Copilot May 16, 2025 19:37

gemini-code-assist bot suggested changes May 16, 2025

View reviewed changes

github-project-automation bot moved this from Backlog to Ready in 💸 Open Prices May 16, 2025

github-project-automation bot moved this from 💬 To discuss and validate to 🏗️ In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 16, 2025

Copilot AI reviewed May 16, 2025

View reviewed changes

g123k closed this Jun 9, 2025

github-project-automation bot moved this from 🏗️ In Progress to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 9, 2025

github-project-automation bot moved this from Ready to Done in 💸 Open Prices Jun 9, 2025

		final _ProofSource? proofSource =
		await _ProofSource.select(context);

Uh oh!

feat: Add receipt and price icons to prices screen #6421

feat: Add receipt and price icons to prices screen #6421

Uh oh!

Conversation

vinay769 commented Mar 6, 2025

What

Screenshot

Part of

Uh oh!

teolemon commented Mar 7, 2025

Uh oh!

vinay769 commented Mar 8, 2025

Uh oh!

AshAman999 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vinay769 commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monsieurtanuki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vinay769 commented Mar 13, 2025

Uh oh!

vinay769 commented Mar 15, 2025

Uh oh!

monsieurtanuki commented Mar 15, 2025

Uh oh!

vinay769 commented Mar 16, 2025

Uh oh!

monsieurtanuki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

monsieurtanuki Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

monsieurtanuki Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

g123k commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinay769 commented Mar 18, 2025

Uh oh!

g123k commented Apr 14, 2025

Uh oh!

vinay769 commented Apr 14, 2025

Uh oh!

teolemon commented May 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Summary of Findings

Merge Readiness

Uh oh!

gemini-code-assist bot May 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot May 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

codecov-commenter commented Mar 10, 2025 •

edited

Loading

vinay769 commented Mar 10, 2025 •

edited

Loading

g123k commented Mar 17, 2025 •

edited

Loading