feat: Add receipt and price icons to prices screen #6421

vinay769 · 2025-03-06T20:16:30Z

What

Added receipt and price icons to the price page to improve visual clarity and user understanding.
Change the RadioListTile Widget to Radio widget to show the icon of receipt and price tag

feat, for Features enhancing User Experience and User Interface

Screenshot

Part of

🎯 What can I work on ? (mobile app) #525 in this what i put in discription here i made changes of putting icons for recepit and prices tag in price page and a screenshot atached

teolemon · 2025-03-07T18:08:06Z

@vinay769 Run dart format --set-exit-if-changed .
Formatted packages/smooth_app/lib/pages/prices/price_proof_card.dart
Formatted 567 files (1 changed) in 1.88 seconds.
Error: Process completed with exit code 1.

vinay769 · 2025-03-08T18:11:31Z

hello @teolemon Ran dart format command and can you please review thanks

AshAman999

Hey @vinay769

Left some comments

packages/smooth_app/lib/pages/prices/price_proof_card.dart

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

packages/smooth_app/pubspec.lock

codecov-commenter · 2025-03-10T12:19:39Z

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 5.84%. Comparing base (4d9c7fc) to head (b5ef09c).
Report is 800 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../smooth_app/lib/pages/prices/price_proof_card.dart	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6421      +/-   ##
==========================================
- Coverage     9.54%   5.84%   -3.71%     
==========================================
  Files          325     490     +165     
  Lines        16411   29259   +12848     
==========================================
+ Hits          1567    1711     +144     
- Misses       14844   27548   +12704

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…t.swift

vinay769 · 2025-03-10T18:30:56Z

done with this thanks to @AshAman999 @teolemon please take a look

monsieurtanuki

Hi @vinay769!

There are conflicts to be fixed, because of recent changes in the master branch.
You should add your IconData in ProofTypeExtension.

I'm very worried about the UI.
You're lucky because your screenshots are in English, with small words.
Would you please try with different longer labels? I suggest "Ticket de caisse" and "Etiquette de prix".

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

vinay769 · 2025-03-13T10:54:45Z

Okay thanks for you valuable feedback @monsieurtanuki i was working on this and get back to you ASAP with great solution

vinay769 · 2025-03-15T18:33:54Z

hello @monsieurtanuki @teolemon

is it okay to put icon after text
is i have a permission to change the font size to fit the text in one line

if both the above answer is yes then the UI is ready to merge
please help me with this
thank you

monsieurtanuki · 2025-03-15T19:30:59Z

Hi @vinay769!
I'm not a big fan of the UI.
Would you try with 2 rows of radio buttons, instead of 2 columns? Please post the screenshots.

vinay769 · 2025-03-16T07:42:45Z

hello @monsieurtanuki

Would you kindly review the following code and provide feedback for optimization?

monsieurtanuki

Hi @vinay769!
Please have a look at my comments.

Would you try with 2 rows of radio buttons, instead of 2 columns? Please post the screenshots.

In case my demand is not explicit enough given the polysemous concepts of rows and columns (especially in flutter), let me draw what I intended.
* Column 1 | * Column 2
and
* Row 1 _______________
* Row 2 _______________

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

packages/smooth_app/lib/pages/prices/proof_type_extensions.dart

monsieurtanuki · 2025-03-16T11:52:18Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

-                      child: RadioListTile<ProofType>(
-                        title: Text(item.getTitle(appLocalizations)),
-                        value: item,
+              children: <Widget>[


You've rolled back the previous code.
Please stick to the previous code unless you have a good reason. Duplicating code is not a good reason.

monsieurtanuki · 2025-03-16T11:55:12Z

packages/smooth_app/lib/pages/prices/price_proof_card.dart

-    final BuildContext context, {
-    required final List<_ProofSource> sources,
-  }) async {
+  static Future<_ProofSource?> select(final BuildContext context) async {


Please stick to the previous code (especially as you've removed bug fixes).
Besides, _ProofSource has nothing to do with the current PR, therefore I wouldn't expect reviewing that code.
Unless there's a good reason.

g123k · 2025-03-17T15:45:36Z

Hello @vinay769,

You can use the following layout:

The toggle is now on top of the screen
For the custom icons, I will add them later (or edit your PR)

This component will be used elsewhere in the app, so don't hesitate to make it generic.
It doesn't necessarily rely on an existing Widget in the Material and Cupertino libs.

vinay769 · 2025-03-18T09:41:39Z

Hello @vinay769,

You can use the following layout:

The toggle is now on top of the screen

For the custom icons, I will add them later (or edit your PR)

This component will be used elsewhere in the app, so don't hesitate to make it generic.
It doesn't necessarily rely on an existing Widget in the Material and Cupertino libs.

Thanks @g123k for this.

…wift

g123k · 2025-04-14T07:32:26Z

Any update on this?
If you can't work on this PR, please let us know.

vinay769 · 2025-04-14T07:59:14Z

Hello @g123k,
I am currently not working on this issue. Please feel free to assign it to someone else who is interested in resolving it.
Thank you!

feat: Add receipt and price icons to prices screen

eedb630

github-project-automation bot added this to 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 6, 2025

github-project-automation bot moved this to 💬 To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 6, 2025

github-actions bot assigned vinay769 Mar 6, 2025

github-actions bot added Prices 🖥️ MacOS labels Mar 6, 2025

github-project-automation bot added this to 💸 Open Prices Mar 6, 2025

github-project-automation bot moved this to Backlog in 💸 Open Prices Mar 6, 2025

vinay769 mentioned this pull request Mar 7, 2025

Add receipt and price tag icons #5904

Open

teolemon linked an issue Mar 7, 2025 that may be closed by this pull request

Add receipt and price tag icons #5904

Open

vinay769 added 4 commits March 8, 2025 22:53

Merge branch 'develop' into feature/receipt-price-icons-ui

db1f5ec

style: Format code to pass CI/CD formatting check

9df5045

style: Format code to pass CI/CD formatting check

9804cd2

style: Format code to pass CI/CD formatting check

3caf9ef

github-actions bot added the PR: needs rebase label Mar 9, 2025

AshAman999 reviewed Mar 9, 2025

View reviewed changes

chore: Remove comments, revert pubspec.lock, GeneratedPluginRegistran…

b5ef09c

…t.swift

github-actions bot removed the PR: needs rebase label Mar 10, 2025

teolemon requested review from g123k, monsieurtanuki and AshAman999 March 13, 2025 09:35

github-actions bot added the PR: needs rebase label Mar 13, 2025

monsieurtanuki reviewed Mar 13, 2025

View reviewed changes

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift Outdated Show resolved Hide resolved

vinay769 added 2 commits March 14, 2025 00:27

Merge origin/develop: Integrate latest develop changes

390257b

updating the price_proof_card

5fa1dc4

feat: Add receipt and price tag icons, support long labels

fb61397

github-actions bot removed the PR: needs rebase label Mar 16, 2025

monsieurtanuki reviewed Mar 16, 2025

View reviewed changes

vinay769 added 2 commits April 7, 2025 12:30

removed packages/smooth_app/pubspec.lock

26fe393

removed packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.s…

8706ee5

…wift

github-actions bot added the PR: needs rebase label Apr 7, 2025

g123k marked this pull request as draft April 17, 2025 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add receipt and price icons to prices screen #6421

feat: Add receipt and price icons to prices screen #6421

vinay769 commented Mar 6, 2025

teolemon commented Mar 7, 2025

vinay769 commented Mar 8, 2025

AshAman999 left a comment

codecov-commenter commented Mar 10, 2025 •

edited

Loading

vinay769 commented Mar 10, 2025 •

edited

Loading

monsieurtanuki left a comment

vinay769 commented Mar 13, 2025

vinay769 commented Mar 15, 2025

monsieurtanuki commented Mar 15, 2025

vinay769 commented Mar 16, 2025

monsieurtanuki left a comment

monsieurtanuki Mar 16, 2025

monsieurtanuki Mar 16, 2025

g123k commented Mar 17, 2025 •

edited

Loading

vinay769 commented Mar 18, 2025

g123k commented Apr 14, 2025

vinay769 commented Apr 14, 2025

feat: Add receipt and price icons to prices screen #6421

Are you sure you want to change the base?

feat: Add receipt and price icons to prices screen #6421

Conversation

vinay769 commented Mar 6, 2025

What

Screenshot

Part of

teolemon commented Mar 7, 2025

vinay769 commented Mar 8, 2025

AshAman999 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 10, 2025 • edited Loading

Codecov Report

vinay769 commented Mar 10, 2025 • edited Loading

monsieurtanuki left a comment

Choose a reason for hiding this comment

vinay769 commented Mar 13, 2025

vinay769 commented Mar 15, 2025

monsieurtanuki commented Mar 15, 2025

vinay769 commented Mar 16, 2025

monsieurtanuki left a comment

Choose a reason for hiding this comment

monsieurtanuki Mar 16, 2025

Choose a reason for hiding this comment

monsieurtanuki Mar 16, 2025

Choose a reason for hiding this comment

g123k commented Mar 17, 2025 • edited Loading

vinay769 commented Mar 18, 2025

g123k commented Apr 14, 2025

vinay769 commented Apr 14, 2025

codecov-commenter commented Mar 10, 2025 •

edited

Loading

vinay769 commented Mar 10, 2025 •

edited

Loading

g123k commented Mar 17, 2025 •

edited

Loading