-
-
Notifications
You must be signed in to change notification settings - Fork 368
fix: New UI for the food preferences #6466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: New UI for the food preferences #6466
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6466 +/- ##
==========================================
- Coverage 9.54% 5.83% -3.71%
==========================================
Files 325 498 +173
Lines 16411 29865 +13454
==========================================
+ Hits 1567 1744 +177
- Misses 14844 28121 +13277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As @monsieurtanuki suggested in #6459 (comment) Shall I commit these changes? Let me know which version looks better
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
Before checking your code, please implement what's in the mockup:
- Help icon VS info
- Edit icon should be aligned with the Help icon…
- Wrong color for the Checkbox
- Titles in bold…
Understood, I am working on that. |
The dot before the titles is still KO. |
Note: This dot is also used in other cards in the app, so you can reuse it if you're not already doing it. |
Thanks for pointing that out! |
Any update on this? |
Apologies for the delay. I’m working on it and will update the PR soon. |
…nal params to replicate from UI render
The dot from the Knowledge panel didn’t match the UI for this screen, so I used circle icon instead. |
What
Refactored Food Preferences UI
Changes
packages/smooth_app/lib/widgets/attribute_button.dart
. Edit mode can now be toggled by pressing the edit option, and once an option is selected from the list, other options are hidden.Card()
in the Food Preferences onboarding screen to preventColorBox
from overwriting the background color ofAttributeButton
.getAttributeDisplayIcon
inpackages/smooth_app/lib/helpers/attributes_card_helper.dart
to reuse the same icon in Food Preferences without code duplication. Implemented the changes inpackages/smooth_app/lib/widgets/attribute_button.dart
packages/smooth_app/lib/pages/preferences/attribute_group_list_tile.dart
.Screenshot
Demo video food preferences screen
food_preferences.mp4
Demo video onboarding screen
onboarding.mp4
Fixes bug(s)
Part of