-
-
Notifications
You must be signed in to change notification settings - Fork 368
feat: Create a compatibility score explainer #6475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6475 +/- ##
==========================================
- Coverage 9.54% 5.84% -3.71%
==========================================
Files 325 497 +172
Lines 16411 29777 +13366
==========================================
+ Hits 1567 1741 +174
- Misses 14844 28036 +13192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I let @g123k review first the PR, specifically about the UI. |
Hi @RahulNavneeth. Thanks for your PR. There are some issues with your implementation:
TLDR: Please implement the design as it's provided in the issue. |
Thank you for reviewing @g123k , working on the changes right away 👍 |
@RahulNavneeth For the record you're supposed to create a branch and to work on it, instead of working on the main |
Understood, @monsieurtanuki 👍. For this particular case, is it okay? I ask because creating a new branch and raising a PR will result in a new PR |
Not sure, I hope it's ok. |
Changes made: 1. Updated `smooth_bottom_sheet`'s `foregroundColor` to enforce the parameter-passed value, ensuring the top banner displays white text. 2. Adjusted the section's color and size to match the design. 3. Added titles for all attributes and applied the appropriate compatibility score color. 4. Added a shadow to the footer button container. 5. Modified the footer button's radius. 6. Recreated the SortDown icon as per the design: - Combined the sort and down icons. 7. Cleaned up the code.
Hi @g123k , I made the requested design changes. Please review. Thanks! |
Issue Reference
Feature Implementation
Changes Implemented in the Existing Codebase
SmoothModalSheet
.SmoothModalSheetHeaderButton
.Screenshots
Video
Before
ScreenRecording_03-25-2025.00-34-09_1.MP4
After
ScreenRecording_03-25-2025.00-30-26_1.mov
Potential Improvements
SmoothIcon
as specified in the design for Create a Compatibility Score explainer #6457 , so I used theclear
icon as a placeholder. Open to suggestions for a better alternative.Additional Notes