fix: Add staticContent to SmoothModalSheet and constrain navbar reord… #6482
Conversation
github-project-automation
bot
moved this to 💬 To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
There was a problem hiding this comment.
Hi @TapItNinja!
Please
- revert what was coded in #6443 first, in order to fix #6451 (and check it does work)
- on top of that, fix again #6441 the way it was coded but without impacting #6451 - as discussed before, just adding a
boolparameter that would make the navbar work exactly as it used to work and the static content exactly as coded in #6443
| @@ -60,12 +64,17 @@ class ProductFooterSettingsButton extends StatelessWidget { | |||
| /// Header + list padding + for each action: height + separator | |||
| /// + bottom padding (nav bar) | |||
| double _computeContentSize(BuildContext context) { | |||
| return SmoothModalSheetHeader.MIN_HEIGHT + | |||
| final double availableHeight = | |||
There was a problem hiding this comment.
Please keep your comments to the very very very minimum, in general for this PR.
| @@ -49,8 +49,12 @@ class ProductFooterSettingsButton extends StatelessWidget { | |||
| title: appLocalizations.product_page_action_bar_setting_modal_title, | |||
| prefixIndicator: true, | |||
| closeButton: true, | |||
| expandBody: true, | |||
| body: const _ProductActionBarModal(), | |||
| expandBody: false, // Avoid unbounded expansion | |||
There was a problem hiding this comment.
If I were you I wouldn't recode this part with your personal tastes.
The point here is not to change the way it used to be, the point is to put it how it was before.
The only thing you should do here is say "btw it's dynamic content" (or "not static", whatever), with an additional parameter.
| @@ -318,6 +318,7 @@ class SmoothModalSheet extends StatelessWidget { | |||
| Color? headerForegroundColor, | |||
| this.bodyPadding, | |||
| this.expandBody = false, | |||
| this.staticContent = false, // New parameter | |||
There was a problem hiding this comment.
How come is it false by default?
Most of the time it's stupid static content like "blablabla click-ok", isn't it?
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the navbar reordering crash (#6451) by refining modal layout behavior and content sizing. The key changes include:
- Adjusting the product footer settings modal to use a fixed height container and disabling automatic expansion.
- Capping the computed content size at 80% of the screen height.
- Replacing SmoothAnimatedList with ListView.separated for a more predictable layout.
- Introducing a new staticContent parameter in SmoothModalSheet and modifying its layout wrapping logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/smooth_app/lib/pages/product/product_page/footer/new_product_footer_settings.dart | Updated modal layout: fixed SizedBox for body and revised content size calculation |
| packages/smooth_app/lib/generic_lib/bottom_sheets/smooth_bottom_sheet.dart | Added staticContent parameter and refactored body wrapping conditions |
Comments suppressed due to low confidence (1)
packages/smooth_app/lib/pages/product/product_page/footer/new_product_footer_settings.dart:52
- Consider verifying that disabling expandBody while using a SizedBox for the body is consistently aligned with the intended modal behavior across different screen sizes. Additionally, ensure that the 'size' variable used on line 55 is clearly defined in the surrounding context.
expandBody: false, // Avoid unbounded expansion
| @@ -348,8 +350,10 @@ class SmoothModalSheet extends StatelessWidget { | |||
| child: body, | |||
| ); | |||
|
|
|||
| if (expandBody) { | |||
| bodyChild = Expanded(child: bodyChild); | |||
| if (expandBody && !staticContent) { | |||
There was a problem hiding this comment.
The conditional logic that wraps the body in a scroll view based on the staticContent flag could benefit from a clearer structure. Consider refactoring this logic to make the separation of dynamic versus static content behavior more explicit.
Copilot uses AI. Check for mistakes.
github-project-automation
bot
moved this from 💬 To discuss and validate
to 🎊 Done
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
Fixes navbar reordering crash (#6451) due to unbounded height post-#6443:
staticContenttoSmoothModalSheet(@monsieurtanuki’s suggestion)._computeContentSizeat 80% screen height.SmoothAnimatedListwithListView.separated(shrinkWrap: true).Tested across devices—no errors. Balances #6443’s fix with functionality. Open to reverting #6443 if @g123k prefers!
Fixes #6451, updates #6462.
Simulator.Screen.Recording.-.iPhone.16.-.2025-03-27.at.16.22.45.mp4