fix: Add staticContent to SmoothModalSheet and constrain navbar reord… #6482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 💬 To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
There was a problem hiding this comment.
Hi @TapItNinja!
Please
- revert what was coded in fix: Fixed issue 'DraggableScrollableSheet assertion error' #6441 #6443 first, in order to fix The reordering system in the navbar is broken #6451 (and check it does work)
- on top of that, fix again Product list selection modal shows 'DraggableScrollableSheet assertion error:' on small devices #6441 the way it was coded but without impacting The reordering system in the navbar is broken #6451 - as discussed before, just adding a
boolparameter that would make the navbar work exactly as it used to work and the static content exactly as coded in fix: Fixed issue 'DraggableScrollableSheet assertion error' #6441 #6443
| @@ -60,12 +64,17 @@ class ProductFooterSettingsButton extends StatelessWidget { | |||
| /// Header + list padding + for each action: height + separator | |||
| /// + bottom padding (nav bar) | |||
| double _computeContentSize(BuildContext context) { | |||
| return SmoothModalSheetHeader.MIN_HEIGHT + | |||
| final double availableHeight = | |||
There was a problem hiding this comment.
Please keep your comments to the very very very minimum, in general for this PR.
| @@ -49,8 +49,12 @@ class ProductFooterSettingsButton extends StatelessWidget { | |||
| title: appLocalizations.product_page_action_bar_setting_modal_title, | |||
| prefixIndicator: true, | |||
| closeButton: true, | |||
| expandBody: true, | |||
| body: const _ProductActionBarModal(), | |||
| expandBody: false, // Avoid unbounded expansion | |||
There was a problem hiding this comment.
If I were you I wouldn't recode this part with your personal tastes.
The point here is not to change the way it used to be, the point is to put it how it was before.
The only thing you should do here is say "btw it's dynamic content" (or "not static", whatever), with an additional parameter.
| @@ -318,6 +318,7 @@ class SmoothModalSheet extends StatelessWidget { | |||
| Color? headerForegroundColor, | |||
| this.bodyPadding, | |||
| this.expandBody = false, | |||
| this.staticContent = false, // New parameter | |||
There was a problem hiding this comment.
How come is it false by default?
Most of the time it's stupid static content like "blablabla click-ok", isn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes navbar reordering crash (#6451) due to unbounded height post-#6443:
staticContenttoSmoothModalSheet(@monsieurtanuki’s suggestion)._computeContentSizeat 80% screen height.SmoothAnimatedListwithListView.separated(shrinkWrap: true).Tested across devices—no errors. Balances #6443’s fix with functionality. Open to reverting #6443 if @g123k prefers!
Fixes #6451, updates #6462.
Simulator.Screen.Recording.-.iPhone.16.-.2025-03-27.at.16.22.45.mp4