Skip to content

feat: revamp authentication modal with enhanced UI #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

cherish2003
Copy link
Contributor

What

  • Adds stamp-like animation for the chips
  • Optimized text handling for multi-language support
  • Prevents unwanted scrolling while maintaining content visibility

Screenshot

flutter_01

Demo

c37311ca47fd46b6bf8488a2b5981d1a.mp4

Fixes bug(s)

Part of

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 0.54348% with 183 lines in your changes missing coverage. Please review.

Project coverage is 5.85%. Comparing base (4d9c7fc) to head (ce3715c).
Report is 812 commits behind head on develop.

Files with missing lines Patch % Lines
...s/user_management/authentication_bottom_sheet.dart 0.54% 182 Missing ⚠️
...pp/lib/pages/product/common/product_refresher.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6488      +/-   ##
==========================================
- Coverage     9.54%   5.85%   -3.70%     
==========================================
  Files          325     497     +172     
  Lines        16411   29724   +13313     
==========================================
+ Hits          1567    1741     +174     
- Misses       14844   27983   +13139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teolemon teolemon requested a review from g123k March 29, 2025 10:01
@g123k
Copy link
Collaborator

g123k commented Mar 29, 2025

Hi @cherish2003!

Thanks for your PR.
Before reviewing your code, please implement the UI as given in the issue.

A non-exhaustive list of issues:

  • Wrong text size
  • Incorrect buttons (sizes, colors, shadows…)
  • Why "for free" in orange?
  • Header is too big
  • The brown color from the header should go underneath the card
  • For buttons : one is green and the other is white with a green border
  • For buttons : the animation should be slower. Once a button is not in the foreground, the opacity is reduced

cherish2003 and others added 2 commits March 31, 2025 03:38
@cherish2003
Copy link
Contributor Author

@g123k apologies for the list of issues. I have rectified them as per the requirements
attached is the latest UI for your review. Let me know if any further changes are needed. Thank you for your time 🙂

Screenshot

WhatsApp Image 2025-03-31 at 3 31 12 AM

Demo

1ee1aad94fb6432786fcebfab6af0603.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

Revamp the "user not connected" popup
3 participants