fix: Removed the option to add an item through barcode from Add a Price page

[Abhishek-P0207]

What

Fixed the issue of adding an unrelated item through barcode, from "Add a price" page of a specific product.

Screenshot

Before:

After:

Fixes bug(s)

• Fixes: You shouldn't be able to add an unrelated price from the page of a product  #6448

Part of

• 🎯 What can I work on ? (mobile app) #525

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 5.81%. Comparing base (4d9c7fc) to head (d60b9d1).
Report is 860 commits behind head on develop.

Files with missing lines	Patch %	Lines
...kages/smooth_app/lib/pages/prices/price_model.dart	0.00%	1 Missing ⚠️
.../smooth_app/lib/pages/prices/price_proof_page.dart	0.00%	1 Missing ⚠️
...h_app/lib/pages/prices/product_price_add_page.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6525      +/-   ##
==========================================
- Coverage     9.54%   5.81%   -3.74%     
==========================================
  Files          325     501     +176     
  Lines        16411   29996   +13585     
==========================================
+ Hits          1567    1745     +178     
- Misses       14844   28251   +13407     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[monsieurtanuki]

Hi @Abhishek-P0207!
Correct me if I'm wrong, but you've just removed the "add a product" block altogether, right?
That's not what was supposed to be done:

• there are cases when we land on that page from a single product page, and in that case only we shouldn't be able to add products
• there are cases when we land on that page from a "add prices from receipt" button, and in that case we should definitely be able to add products (especially as we start with an empty list of products)

[Abhishek-P0207]

Hmm , I will fix it.

[Abhishek-P0207]

@monsieurtanuki I fixed it, but I have a doubt regarding the "Add price tags" button in the prices section.
Both "Add a receipt" and "Add price tags" go to the same page, then why separate buttons, also in the adding section we provide a radio button to switch between them.We can combine them in one single button right?

[Abhishek-P0207]

The "Add price tags" should not have option of Add an item right?
As, it is not possible to have a list of items like that of a receipt, in the form of a price tag. The receipt can contain bill for single item or multiple items right? But price tag will only contain a single item. We can add the proof of receipt, and add multiple items but i don't know how Add price tags work!!
Can you clarify this @monsieurtanuki

[monsieurtanuki]

I fixed it

You did? Where's the code?

but I have a doubt regarding the "Add price tags" button in the prices section. Both "Add a receipt" and "Add price tags" go to the same page

That's correct

then why separate buttons, also in the adding section we provide a radio button to switch between them.We can combine them in one single button right?

Don't worry, keep it that way.

[monsieurtanuki]

The "Add price tags" should not have option of Add an item right?

Yes it should

[Abhishek-P0207]

@monsieurtanuki The issue is fixed, please review it.

[monsieurtanuki]

Hi @Abhishek-P0207!
Unfortunately your solution doesn't work.
It should NOT depend on the current status (what if I switch from receipt to price tag? what if I start with an empty list and add one product?).
The solution is in the model: "hey, just don't show an 'add product' button". And that bool could be set as a final in the model creation, depending on where you opened the "add price" page.

[Abhishek-P0207]

Hmm, Interesting. I will look into it. As Lab exams are going on now, I am not able to contribute in a continuous basis. exams will be over by day after tmrw, so can i contribute from then on? I will try to fix this if I find any free time in between.
Thank you

[monsieurtanuki]

Hi @Abhishek-P0207, and thank you for your code rewriting!
Please have a look at my comments.

Additional comments:

• I would have named the field "singleProduct" instead of "multipleProducts" (obviously with the opposite purpose), but it's just a matter of taste
• generally speaking it's not such a good idea to use default values when the default choice is not that obvious. More specifically here, without the default value the developer is explicitly asked "is that a single product model?", and it's a fair question to ask.

[monsieurtanuki]

Suggested change

	final bool? multipleProducts,
	required this.multipleProducts,

[monsieurtanuki]

Suggested change

_multipleProducts = multipleProducts ?? false,

[monsieurtanuki]

Suggested change

	late bool _multipleProducts;
	bool showAddProductCard() {
	if (_multipleProducts == true) {
	return true;
	}
	return false;
	}
	/// "Should we support multiple products?" (instead of a single)
	final bool multipleProducts;

For the record, your previous syntax was a bit heavy:

  bool showAddProductCard() {
    if (_multipleProducts == true) {
      return true;
    }
    return false;
  }

The following would have been better:

  bool get showAddProductCard => _multipleProducts;

[monsieurtanuki]

Suggested change

	multipleProducts: multiProduct,
	multipleProducts: multipleProducts,

Please try to keep consistency between classes.

[monsieurtanuki]

Suggested change

	if (model.showAddProductCard()) const PriceAddProductCard(),
	if (model.multipleProducts) const PriceAddProductCard(),

[monsieurtanuki]

Hi @Abhishek-P0207, and thank you for that clean code: now we can focus on the actual functionalities.

I believe there are still a couple of things to fix:

• we should always be able to add several products to an existing proof, so there shouldn't be a multipleProducts parameter to PriceModel.proof, and the field should be set to true
• method ProductPriceAddPage.showProductPage doesn't need a multipleProducts parameter. It should just compute a multipleProducts field as product == null

[monsieurtanuki]

I believe it's always true for proofs: we have an existing proof, and we want to add products to it. No reason to limit to just one product here.

[monsieurtanuki]

No, should be true: we can add several products to a proof.

[monsieurtanuki]

Looks good to me, thank you @Abhishek-P0207!

[Abhishek-P0207]

Thanks @monsieurtanuki, Learnt a lot of things.😃