Skip to content

fix: Better convey privacy in the Food Settings screen #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tshrrx
Copy link

@tshrrx tshrrx commented Apr 6, 2025

What

Refactored UI to better convey privacy in Food Preferences page aligning with current release UI.

###Changes

  • Simplified the On-device message. Made the message shorter and easier to understand.
  • Added Privacy Icon for Emphasis. 'packages\smooth_app\assets\icons\privacy.png'
  • Displayed the message using 'UserPreferencesItemSimple' in packages\smooth_app\lib\pages\preferences\user_preferences_food.dart.
  • Applied custom styling using Container with theme-based colors.

Ready to roll out PR for new UI after merging of fix for New UI for the food preferences #6459

Screenshot

Before:
image
After:
-Dark Theme
image
-Light Theme
image
-Onboarding
image

Fixes bug(s)

Part of

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 5.89%. Comparing base (4d9c7fc) to head (9510ef9).
Report is 834 commits behind head on develop.

Files with missing lines Patch % Lines
...p/lib/pages/preferences/user_preferences_food.dart 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6527      +/-   ##
==========================================
- Coverage     9.54%   5.89%   -3.66%     
==========================================
  Files          325     496     +171     
  Lines        16411   29586   +13175     
==========================================
+ Hits          1567    1743     +176     
- Misses       14844   27843   +12999     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@monsieurtanuki monsieurtanuki requested a review from teolemon April 13, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
3 participants