Skip to content

fix(onboarding): prevent welcome screen text overflow in localized languages#7386

Open
Hars465465 wants to merge 1 commit intoopenfoodfacts:developfrom
Hars465465:develop
Open

fix(onboarding): prevent welcome screen text overflow in localized languages#7386
Hars465465 wants to merge 1 commit intoopenfoodfacts:developfrom
Hars465465:develop

Conversation

@Hars465465
Copy link
Copy Markdown

What

Screenshot

Fixes bug(s)

  • Fixes:

Part of

@github-actions github-actions Bot added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Jan 23, 2026
@Hars465465 Hars465465 changed the title Fix welcome screen text overflow for localized languages fix(onboarding): prevent welcome screen text overflow in localized languages Jan 23, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.13%. Comparing base (4d9c7fc) to head (5f77fa3).
⚠️ Report is 1326 commits behind head on develop.

Files with missing lines Patch % Lines
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #7386      +/-   ##
==========================================
- Coverage     9.54%   9.13%   -0.42%     
==========================================
  Files          325     624     +299     
  Lines        16411   36534   +20123     
==========================================
+ Hits          1567    3337    +1770     
- Misses       14844   33197   +18353     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@g123k
Copy link
Copy Markdown
Collaborator

g123k commented Jan 23, 2026

Which issue do you fix?
I see no issue assigned to you (= this a requirement before beginning)

@Hars465465
Copy link
Copy Markdown
Author

Thanks for pointing this out.

This PR fixes issue #7386 (welcome screen text overflow for localized languages).

I started working on it before the assignment requirement was clear to me — apologies for that.
I’ll make sure to get explicit assignment before starting work on future issues.

Please let me know if anything needs to be adjusted.

@openfoodfacts-bot
Copy link
Copy Markdown
Collaborator

@Hars465465 can you add a screenshot of your change in the PR ?

@Hars465465
Copy link
Copy Markdown
Author

Here is a screenshot from my local run with the app set to German.

Before this change, the welcome screen text was clipped and the final word
“sind!” was not visible. After removing the fixed height constraint, the
text expands naturally and the full sentence is now displayed.
WhatsApp Image 2026-01-27 at 11 46 52 AM

@Hars465465
Copy link
Copy Markdown
Author

Hi maintainers,

I would really appreciate feedback on this PR.
Happy to make any required changes.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Projects

Status: 💬 To discuss and validate

Development

Successfully merging this pull request may close these issues.

5 participants