Skip to content

fix: Spellchecker on Product Name field#7447

Open
SISIR-REDDY wants to merge 1 commit into
openfoodfacts:developfrom
SISIR-REDDY:fix-5415-spellchecker
Open

fix: Spellchecker on Product Name field#7447
SISIR-REDDY wants to merge 1 commit into
openfoodfacts:developfrom
SISIR-REDDY:fix-5415-spellchecker

Conversation

@SISIR-REDDY
Copy link
Copy Markdown

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.10%. Comparing base (4d9c7fc) to head (b3912ad).
⚠️ Report is 1354 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #7447      +/-   ##
==========================================
- Coverage     9.54%   9.10%   -0.45%     
==========================================
  Files          325     625     +300     
  Lines        16411   36638   +20227     
==========================================
+ Hits          1567    3337    +1770     
- Misses       14844   33301   +18457     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teolemon teolemon requested a review from Copilot April 9, 2026 07:43
@teolemon
Copy link
Copy Markdown
Member

teolemon commented Apr 9, 2026

@SISIR-REDDY we're short on reviewing power, so I requested a Copilot initial review meanwhile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables OS spellchecking for the Product Name input in the product “Add basic details” flow, addressing issue #5415.

Changes:

  • Turned on spellCheckConfiguration for the Product Name SmoothTextFormField.

),
allowEmojis: false,
maxLines: 1,
spellCheckConfiguration: const SpellCheckConfiguration(),
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables spellcheck unconditionally. Elsewhere spellcheck is explicitly guarded to mobile platforms (e.g., EditOCRTextField enables it only when Platform.isAndroid || Platform.isIOS). If the intent is to enable spellcheck only where supported/desired, consider adding the same platform guard here and using SpellCheckConfiguration.disabled() otherwise.

Suggested change
spellCheckConfiguration: const SpellCheckConfiguration(),
spellCheckConfiguration:
Platform.isAndroid || Platform.isIOS
? const SpellCheckConfiguration()
: const SpellCheckConfiguration.disabled(),

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 💬 To discuss and validate

Development

Successfully merging this pull request may close these issues.

Spellchecker on Product Name field

4 participants