Skip to content

fix: Improve runtime performance for product decoding and barcode list operations #7501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lguiza wants to merge 2 commits into
base: develop
Choose a base branch
from
+14 −16
Open

fix: Improve runtime performance for product decoding and barcode list operations #7501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00aa9e
Optimize barcode exclusion lookups using Set
lguiza May 13, 2026
e15ca26
Optimize bulk barcode membership checks with LinkedHashSet
lguiza May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/smooth_app/lib/database/dao_product.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ class DaoProduct extends AbstractSqlDao implements BulkDeletable {

Future<List<String>> getAllKeys() async {
final List<String> result = <String>[];
final Set<String> excluded = excludeBarcodes.toSet();
final List<Map<String, dynamic>> queryResults = await localDatabase.database
.query(
_TABLE_PRODUCT,
Expand Down Expand Up @@ -433,7 +434,7 @@ class DaoProduct extends AbstractSqlDao implements BulkDeletable {
while (await queryCursor.moveNext()) {
final String barcode =
queryCursor.current[_TABLE_PRODUCT_COLUMN_BARCODE]! as String;
if (excludeBarcodes.contains(barcode)) {
if (excluded.contains(barcode)) {
continue;
}
String? foundProductType =
Expand Down
27 changes: 12 additions & 15 deletions packages/smooth_app/lib/database/dao_product_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:async';
import 'dart:convert';
import 'dart:collection';

import 'package:hive_flutter/hive_flutter.dart';
import 'package:openfoodfacts/openfoodfacts.dart';
Expand Down Expand Up @@ -235,28 +236,24 @@ class DaoProductList extends AbstractDao {
final bool include = true,
}) async {
final _BarcodeList? list = await _get(productList);
final List<String> allBarcodes;

final LinkedHashSet<String> allBarcodes;
if (list == null) {
allBarcodes = <String>[];
allBarcodes = LinkedHashSet<String>();
} else {
allBarcodes = _getSafeBarcodeListCopy(list.barcodes);
allBarcodes = LinkedHashSet<String>.from(list.barcodes);
}

for (final String barcode in barcodes) {
if (include) {
if (!allBarcodes.contains(barcode)) {
allBarcodes.add(barcode);
}
} else {
if (allBarcodes.contains(barcode)) {
allBarcodes.remove(barcode);
}
}
if (include) {
allBarcodes.add(barcode);
} else {
allBarcodes.remove(barcode);
}
}
}

final _BarcodeList newList = _BarcodeList.now(allBarcodes);
await _put(getKey(productList), newList);
final _BarcodeList newList =
_BarcodeList.now(allBarcodes.toList());
}

Future<ProductList> rename(
Expand Down
Loading