fix: 7473 - nutrition facts with not pinned and more compact header#7510
Open
monsieurtanuki wants to merge 3 commits into
Open
fix: 7473 - nutrition facts with not pinned and more compact header#7510monsieurtanuki wants to merge 3 commits into
monsieurtanuki wants to merge 3 commits into
Conversation
Impacted files: * `nutrition_page.dart`: unpinned the sliver header, display the text and the button in a column instead of a row * `pubspec.lock`: wtf * `smooth_sliver_card.dart`: added a "pinned" parameter
github-project-automation
Bot
moved this to 💬 To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7510 +/- ##
==========================================
- Coverage 9.54% 8.99% -0.56%
==========================================
Files 325 638 +313
Lines 16411 37286 +20875
==========================================
+ Hits 1567 3353 +1786
- Misses 14844 33933 +19089 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pinned header in the nutrition page prevented users from accessing the important thing: the text fields.
Here we unpin the header: when we scroll down the header disappears and leaves all the needed space.
The header itself changes, as it was unbalanced between a long description text and an action button.
Screenshots
Fixes bug(s)
Part of
~,<and>#7437Impacted files
nutrition_page.dart: unpinned the sliver header, display the text and the button in a column instead of a rowpubspec.lock: wtfsmooth_sliver_card.dart: added a "pinned" parameter