Conversation
github-project-automation
Bot
moved this to 💬 To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
Contributor
🔍 Translation Validation ReportThis is an automated check of translation quality. Issues found are informational and don't block the PR.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1bd7d7b0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "@Lists": {}, | ||
| "no_prodcut_in_list": "There is no product in this list", | ||
| "no_product_in_list": "There is no product in this list", |
There was a problem hiding this comment.
Changing only the English template key here makes no_product_in_list a new message while the existing translations are left behind under no_prodcut_in_list in the other locale ARBs (I found 127 app_*.arb files still using the old key and only app_en.arb using the new one). After gen-l10n, non-English locales for this empty-list message will fall back to the English text and the existing translations become unused; either keep the original key and fix only the visible string, or rename the key consistently across all locale files and regenerate localizations.
Useful? React with 👍 / 👎.
Contributor
🌍 Translation Quality ReportThis report combines multiple translation quality checks: 🔍 Translation Validation ReportThis is an automated check of translation quality. Issues found are informational and don't block the PR.
|
Closed
github-project-automation
Bot
moved this from 💬 To discuss and validate
to 🎊 Done
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Fix typos in localization strings
no_prodcut_in_list
scan with 2 n