Separate variant owner supplier 2 14201#14393
Draft
dacook wants to merge 11 commits into
Draft
Conversation
I'm sorry for the detour this was, but I'm sure everyone will be glad to see it gone..
I was troubleshooting a problem and found that these names took too much effort to understand. Maybe I just have a short attention span but hopefully this is helpful for others too.
Some of this was originally generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
dacook
force-pushed
the
separate-variant-owner-supplier-2-14201
branch
2 times, most recently
from
36dfa2a to
5f57a55
Compare
sigmundpetersen
moved this from All the things 💤
to In Progress ⚙
in OFN Delivery board
dacook
force-pushed
the
separate-variant-owner-supplier-2-14201
branch
from
5f57a55 to
3bab298
Compare
Also some of the parameter documentation was out of date.
Gee that was a big one.
The bulk quick search uses partial matching (_cont) across fields, including distributor name, so autogenerated enterprise names can collide by substring and make this spec flaky. This change keeps the test intent intact while removing random name-collision flakiness.
This reverts commit 36dfa2a. Co-pilot was very convincing, but wrong.
These are just the ones I found with searching. More might pop up when we remove the column.
dacook
force-pushed
the
separate-variant-owner-supplier-2-14201
branch
from
3bab298 to
c178b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates