Fix Payments tab redirect for awaiting_return and returned orders#14409
Open
NiftyGaloot wants to merge 1 commit into
Open
Fix Payments tab redirect for awaiting_return and returned orders#14409NiftyGaloot wants to merge 1 commit into
NiftyGaloot wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes Payments tab redirects to Customer Details for orders with a return authorization #14404
When a Return Authorization is created against a completed order, the order state
transitions to
awaiting_return(orreturnedafter the RMA is received). ThePayments tab remains visible in the admin order edit page, but clicking it redirects
to Customer Details with "Please fill in the customer details before proceeding to
payment".
The cause is
can_transition_to_paymentinPaymentsController, which only allowsaccess for
confirmation,payment,complete,canceled, andresumedstates.Both
awaiting_returnandreturnedare post-completion states \u2014 the order hasalready passed through checkout \u2014 so their exclusion from the whitelist is accidental.
Fix: add
awaiting_return?andreturned?to the guard condition.What should we test?
Create a completed order with at least one line item and a shipment.
Visit ... page.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.