Skip to content

fix(openfort-swift): update skill file against Swift SDK v1.0.1#26

Open
emauja wants to merge 1 commit into
mainfrom
fix/openfort-swift-skill-review-v1.0.1
Open

fix(openfort-swift): update skill file against Swift SDK v1.0.1#26
emauja wants to merge 1 commit into
mainfrom
fix/openfort-swift-skill-review-v1.0.1

Conversation

@emauja

@emauja emauja commented Apr 16, 2026

Copy link
Copy Markdown

Summary

  • Remove passkey references (not supported in Swift SDK)
  • Fix debug config key to required (Bool, not Bool?)
  • Add missing callbackURL param to OFVerifyEmailParams
  • Add 17 previously undocumented SDK methods covering phone OTP, SIWE login, OAuth/wallet linking, account management, token validation, and session signatures

SDK Version

Verified against openfort-xyz/swift-sdk tag 1.0.1 (latest as of 2026-04-16)

What Changed

Category Change
Passkey removal Removed .passkey from OFRecoveryMethod enum and passkeyInfo from OFRecoveryParamsDTO — Passkeys are not supported
Config fix debug in OFConfig.plist table changed from optional to required
Param fix Added callbackURL: String? to OFVerifyEmailParams
New: Phone OTP requestPhoneOtp, logInWithPhoneOtp, linkPhoneOtp
New: SIWE login loginWithSiwe (direct single-step SIWE auth)
New: SIWE linking initLinkSiwe, linkWithSiwe
New: OAuth linking initLinkOAuth, poolOAuth, unlinkOAuth
New: Wallet linking linkWallet, unlinkWallet
New: Email mgmt addEmail, verifyEmailOtp
New: Account ops get, create, recover, list
New: Token mgmt validateAndRefreshToken
New: Session sig sendSignatureSessionRequest

Note

The openfort-xyz/documentation repository referenced in the review schedule does not exist. Only the skill file (Part 1) was reviewed. Remaining undocumented utility methods (ping, getEmbeddedState, getURL) were omitted as they are internal/diagnostic.

Fixes #25

🤖 Generated with Claude Code

- Remove passkey references (not supported in Swift SDK)
- Fix debug config key to required (Bool, not Bool?)
- Add missing callbackURL param to OFVerifyEmailParams
- Add phone OTP auth methods (requestPhoneOtp, logInWithPhoneOtp, linkPhoneOtp)
- Add direct SIWE login (loginWithSiwe)
- Add SIWE wallet linking (initLinkSiwe, linkWithSiwe)
- Add OAuth linking methods (initLinkOAuth, poolOAuth, unlinkOAuth)
- Add wallet link/unlink methods (linkWallet, unlinkWallet)
- Add email management (addEmail, verifyEmailOtp)
- Add embedded account management (get, create, recover, list)
- Add token management (validateAndRefreshToken)
- Add session signature request (sendSignatureSessionRequest)

Fixes #25

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@emauja

emauja commented Apr 20, 2026

Copy link
Copy Markdown
Author

Re-verification (2026-04-20)

Re-verified against openfort-xyz/swift-sdk tag 1.0.1 (latest — unchanged since this PR was created).

All changes in this PR remain accurate and necessary:

  • ✅ Passkey removal still correct (Passkeys not supported)
  • debug config key fix still needed (Bool, not Bool?)
  • callbackURL addition to OFVerifyEmailParams still needed
  • ✅ All 17 newly documented methods verified against SDK source

No additional discrepancies found beyond what this PR addresses. Recommend merge.

@emauja

emauja commented Apr 23, 2026

Copy link
Copy Markdown
Author

Re-verification (2026-04-23)

Re-verified against openfort-xyz/swift-sdk tag 1.0.1 (commit 7558e0d) — still the latest published tag (unchanged since 2026-02-06).

No new SDK changes since the previous re-verification on 2026-04-20. The only post-tag commit on main is 0e27492 ("fix: remove deprecated ecosystemGame parameter", 2026-03-20), which is unreleased and intentionally excluded from documentation per the deprecation policy.

All fixes in this PR remain correct and necessary:

  • Passkey removal (Passkeys not supported by Swift SDK)
  • debug config key typed as Bool (not Bool?)
  • callbackURL: String? added to OFVerifyEmailParams (verified against Sources/OpenfortSwift/DTO/OFVerifyEmailParams.swift@1.0.1)
  • 17 newly documented methods verified against the protocol files in Sources/OpenfortSwift/Protocols/ at tag 1.0.1

Recommend merge. No additional discrepancies; the skill file is accurate once this PR lands.


Automated re-verification by worker-6 (task 49a0ac6f-75cf-40eb-932b-443a504f5b1c).

@emauja

emauja commented Apr 27, 2026

Copy link
Copy Markdown
Author

Re-verification (2026-04-27)

Re-verified against openfort-xyz/swift-sdk tag 1.0.1 (commit 7558e0d) — still the latest published tag, unchanged since 2026-02-06.

No new SDK changes since the previous re-verification on 2026-04-23:

  • Latest release tag: 1.0.1 (no new tags)
  • Only post-tag commit on main is 0e27492 (2026-03-20, removes deprecated ecosystemGame) — still unreleased and per policy not documented anyway.

All findings in this PR remain accurate and necessary. Ready for review.

Task target mismatches still present in the upstream review prompt

  • The prompt references openfort-xyz/openfort-swift — actual repo is openfort-xyz/swift-sdk.
  • The prompt references openfort-xyz/documentation — that repo does not exist (404).
  • The prompt references skill path public/skills/openfort-swift.md — actual path is skills/embedded-wallet/references/openfort-swift.md in this repo (openfort-xyz/agent-skills).

cc @tarasyarema — this PR has been waiting for review since 2026-04-16. Could a maintainer take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openfort-swift skill: accuracy review against Swift SDK v1.0.1

1 participant