fix: restore laminar chart templates and api tracing#24
Merged
Conversation
Upstream removed laminar in 6a96324, but our deployment still routes laminar-centaur.fort.dev through cloudflared and the api/slackbot/chatbot pods already have LMNR_* env vars baked in. Without the templates the laminar services never get created, so the public route hits a dead backend and the apps log laminar export failures. Restore the deleted contrib/chart/templates/laminar.yaml (6 services, 3 Deployments, 3 StatefulSets reusing the existing PVCs) and the full values block. Also keep services/api/api/laminar_tracing.py so the runtime_control imports resolve. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contrib/chart/templates/laminar.yaml(6 Services + 3 Deployments + 3 StatefulSets) that upstream deleted in 6a96324 "fix: remove laminar support for refactoring". The Helm release on centaur-vps still routeslaminar-centaur.fort.devthrough cloudflared/socat to the laminar-frontend service, the laminar PVCs are still bound (40 GB of data), and api/slackbot/chatbot pods already haveLMNR_*env vars baked in — so the public route was hitting a dead backend.laminar:block incontrib/chart/values.yamlso the chart can render again._helpers.tpldefinitions (centaur.laminarBaseUrl,centaur.laminarNoProxyHosts).services/api/api/laminar_tracing.py(already untracked locally, imported byruntime_control.py).tokenBroker.enabled=falseandnetworkPolicy.enabled=falseinvalues.dev.yamlto match the actual running cluster.Why
Upstream removed laminar to refactor it; we still depend on it for tracing the Slackbot + Chatbot. After the upstream sync merged that deletion, our cluster was left with half-restored config (env vars present, services missing). PVCs and cloudflared route survived; the partial restoration was sitting uncommitted on the centaur-vps host.
Test plan
helm template centaur contrib/chart -n centaur -f contrib/chart/values.dev.yamlrenders cleanlyhelm upgrade --install centaur contrib/chart -n centaur -f contrib/chart/values.dev.yamlapplied to centaur-vps; 6 laminar pods reach Ready in <40sdata-centaur-centaur-laminar-{postgres,clickhouse,quickwit}-0) auto-rebound to the restored StatefulSets, preserving old datacurl http://localhost:5667/returns 307 → /sign-in (laminar Next.js frontend alive)socat-laminar.serviceupdated to the newlaminar-frontendClusterIP and restartedhttps://slack-centaur.fort.dev/healthstill 200 — Slack flow undisrupted; active sandbox conversation continued running through the rollouthttps://laminar-centaur.fort.dev/reaches Cloudflare Access (the 403 is the Access gate, not a backend failure)Follow-ups
laminar-frontendService is recreated, the systemd unit will need its IP updated again. Cleaner: NodePort onlaminar-frontend, or run the forwarder inside the cluster.🤖 Generated with Claude Code