docs(funding): note /v2/funding is now in the OpenAPI spec#315
Open
joalavedra wants to merge 1 commit into
Open
docs(funding): note /v2/funding is now in the OpenAPI spec#315joalavedra wants to merge 1 commit into
joalavedra wants to merge 1 commit into
Conversation
The funding endpoints (tag Funding) are now published in the API's OpenAPI spec, so regenerating @openfort/openapi-clients yields a FundingApi and this hand-rolled wrapper can delegate to BackendApiClients.fundingApi. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@joalavedra is attempting to deploy a commit to the openfort Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the
FundingApidoc comment: the/v2/fundingendpoints are now in the published OpenAPI spec (verified againstapi.openfort.io/api-docs/swagger.json— tagFunding; operationIdscreateFundingSession,SetPaymentMethod,getFundingSession,CreatePayLink,ListChains;fundingSessionschema). The old comment said they weren't yet.Why / follow-up
packages/internal/openapi-clientsis generated from that spec but is stale — it predates funding, soBackendApiClientshas noFundingApiandsdk/src/api/funding.tshand-rolls the calls. Regenerating the client (make generate-backend-openapi) will produce aFundingApi, after which this wrapper can delegate toBackendApiClients.fundingApiwhile keeping the clientSecret memory + ergonomics. This PR just makes the comment accurate and points at that path; the regen + delegation is a follow-up (it needs the Docker/Java generator toolchain).Comment-only change. Funding unit tests pass (7/7); biome clean.
🤖 Generated with Claude Code