chore: standardize Openfort/Shield env var names#318
Open
joalavedra wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Rename client-exposed publishable/key vars to the standard base names: - NEXT_PUBLIC_SHIELD_API_KEY -> NEXT_PUBLIC_SHIELD_PUBLISHABLE_KEY - NEXT_PUBLIC_OPENFORT_PUBLIC_KEY -> NEXT_PUBLIC_OPENFORT_PUBLISHABLE_KEY - VITE_APP_SHIELD_PUBLISHABLE_KEY -> VITE_SHIELD_PUBLISHABLE_KEY - VITE_APP_OPENFORT_PUBLISHABLE_KEY -> VITE_OPENFORT_PUBLISHABLE_KEY The NEXTAUTH_-prefixed backend vars (NEXTAUTH_SHIELD_SECRET_KEY, NEXTAUTH_SHIELD_ENCRYPTION_SHARE, NEXTAUTH_OPENFORT_SECRET_KEY) are intentional backend-env names and are left unchanged. PUBLIC_KEY_SHIELD/SECRET_KEY_SHIELD are SDK enum identifiers, not env vars, and are left unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
joalavedra
force-pushed
the
chore/standardize-env-var-names
branch
from
2fe2f76 to
eaab52a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes the Openfort and Shield environment-variable names used across the example apps and the Playwright CI workflow. Publishable keys keep their framework prefix (
NEXT_PUBLIC_/VITE_); secret keys and the encryption share are server-side and carry no public prefix.Renames
NEXT_PUBLIC_SHIELD_API_KEYNEXT_PUBLIC_SHIELD_PUBLISHABLE_KEYNEXT_PUBLIC_OPENFORT_PUBLIC_KEYNEXT_PUBLIC_OPENFORT_PUBLISHABLE_KEYNEXTAUTH_SHIELD_SECRET_KEYSHIELD_SECRET_KEYNEXTAUTH_SHIELD_ENCRYPTION_SHARESHIELD_ENCRYPTION_SHARENEXTAUTH_OPENFORT_SECRET_KEYOPENFORT_SECRET_KEYVITE_APP_SHIELD_PUBLISHABLE_KEYVITE_SHIELD_PUBLISHABLE_KEYVITE_APP_OPENFORT_PUBLISHABLE_KEYVITE_OPENFORT_PUBLISHABLE_KEY19 files changed (example
.env*files, READMEs, source underexamples/, and.github/workflows/playwright.yml). The workflow's${{ vars.* }}/${{ secrets.* }}references are renamed to match; the corresponding GitHub Actions repo variables/secrets must be renamed for CI to keep working.Left unchanged
ApiKeyTypeenum valuesPUBLIC_KEY_SHIELD/SECRET_KEY_SHIELD(valuespk_shield/sk_shield) in the generated OpenAPI client (packages/internal/openapi-clients/) are SDK key-type constants, not env vars.VITE_SHIELD_PUBLISHABLE_KEYinexamples/apps/solana-sample/*(already correct) andVITE_SHIELD_URL(out of scope).NEXTAUTH_SECRET/NEXTAUTH_URLvars are present in tracked text files.🤖 Generated with Claude Code