Reject odd-length Solana hex private keys#111
Open
samsamtrum wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects odd-length hex strings in Solana private-key import before decoding them with
Buffer.from(..., "hex").Node truncates a trailing half-byte when decoding odd-length hex, so a malformed key could be decoded into a different byte array and then fail later with a misleading key-length error. This makes the validation explicit for both
0x-prefixed and plain hex input.Checked with:
pnpm install --ignore-scripts --frozen-lockfilepnpm test src/wallets/solana/solanaClient.test.tspnpm check:typespnpm lintpnpm buildgit diff --check